-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
de-dupe order and resource dependencies #5446
Conversation
The following is the coverage report on the affected files.
|
2759512
to
09c49f9
Compare
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this simplification very much! Thanks for catching the next bottleneck 🙏
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer, rafalbigaj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @pritidesai - could you apply the change to the |
In case of a pipeline with a huge list of redundant dependencies, the list is growing exponentially. This way of calculating the list of dependencies is causing extra delay in the validation cycle. This delay sometimes hit the webhook timeout during validation. This is one of the changes being proposed to make the validation cycle efficient and avoid unneccesary delay.
09c49f9
to
d2fe86e
Compare
thank you @afrittoli for pointing that out 👍 I have applied these changes to |
The following is the coverage report on the affected files.
|
/lgtm |
Do we need to cherry-pick this one too? @pritidesai |
/cherrypick release-v0.37.x |
/cherrypick release-v0.38.x |
/cherrypick release-v0.39.x |
@pritidesai: #5446 failed to apply on top of branch "release-v0.37.x":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pritidesai: #5446 failed to apply on top of branch "release-v0.38.x":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pritidesai: #5446 failed to apply on top of branch "release-v0.39.x":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
In case of a pipeline with a huge list of redundant dependencies, the list of dependencies is growing exponentially. This way of calculating the list of dependencies is causing extra delay in the validation cycle. This delay sometimes hit the webhook timeout during validation. This is one of the changes being proposed to make the validation cycle efficient and avoid unnecessary delay.
Introducing a test case which was running until a timeout was hit (without @rafalbigaj's changes in #5421). Thanks @rafalbigaj for the efficient implementation of building a graph. This test now runs to competition, on average taking 3 minutes. With the changes in this PR, this test runs under two seconds.
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes