Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ko to v0.12.0 #5539

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Update ko to v0.12.0 #5539

merged 1 commit into from
Sep 23, 2022

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Sep 22, 2022 •
edited
Loading

This ko version fixes ko-build/ko#776 which should resolve #5188

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

/release-note-none

@khrm
Update ko to v0.12.0
d0d49c5 
This ko version fixes ko-build/ko#776 which should resolve
tektoncd#5188
@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 22, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 22, 2022
khrm
khrm commented Sep 22, 2022
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Sep 22, 2022
@khrm
Copy link
Contributor Author

khrm commented Sep 22, 2022

/release-note-none

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 22, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2022
@dibyom
Copy link
Member

dibyom commented Sep 22, 2022

/lgtm

@khrm we also need to apply this to the cluster

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2022
@khrm
Copy link
Contributor Author

khrm commented Sep 23, 2022

/test pull-tekton-pipeline-integration-tests

@khrm
Copy link
Contributor Author

khrm commented Sep 23, 2022

@dibyom How do we apply to cluster? Doesn't the cluster already have this image available?

@tekton-robot tekton-robot merged commit 826d8a0 into tektoncd:main Sep 23, 2022
@khrm khrm deleted the patch-4 branch September 23, 2022 10:11
@dibyom
Copy link
Member

dibyom commented Sep 23, 2022

I meant applying this new publish task to the Tekton dogfooding cluster

@vdemeester vdemeester mentioned this pull request Sep 28, 2022
Closed
@vdemeester
Copy link
Member

/cherry-pick release-v0.40.x

I am doing that because, I am alway applying tasks and pipelines when release from a branch, meaning I won't have this for 0.40.x if I do not cherry-pick 🙃

@tekton-robot tekton-robot mentioned this pull request Sep 28, 2022
Merged
@tekton-robot
Copy link
Collaborator

@vdemeester: new pull request created: #5567

In response to this:

/cherry-pick release-v0.40.x

I am doing that because, I am alway applying tasks and pipelines when release from a branch, meaning I won't have this for 0.40.x if I do not cherry-pick 🙃

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error mirroring git-init image in private registry. Unsupported MIME type for compression
4 participants
@khrm @tekton-robot @dibyom @vdemeester