Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update how-to-write-a-resolver doc #5544

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Update how-to-write-a-resolver doc #5544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/how-to-write-a-resolver.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,8 @@ along with some environment variables and other configuration that the
underlying `knative` framework expects. The deployed application is put
in the `tekton-pipelines` namespace and uses `ko` to build its
container image. Finally the `ServiceAccount` our deployment uses is
`resolver`, which is the default `ServiceAccount` shared by all
resolvers in the `tekton-pipelines` namespace.
`tekton-pipelines-resolvers`, which is the default `ServiceAccount` shared by all
resolvers in the `tekton-pipelines-resolvers` namespace.

The full configuration follows:

Expand All @@ -282,7 +282,7 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: demoresolver
namespace: tekton-pipelines
namespace: tekton-pipelines-resolvers
spec:
replicas: 1
selector:
Expand All @@ -302,7 +302,7 @@ spec:
app: demoresolver
topologyKey: kubernetes.io/hostname
weight: 100
serviceAccountName: resolver
serviceAccountName: tekton-pipelines-resolvers
containers:
- name: controller
image: ko://example.com/demoresolver/cmd/demoresolver
Expand Down
4 changes: 2 additions & 2 deletions docs/resolver-template/config/demo-resolver-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: demoresolver
namespace: tekton-pipelines
namespace: tekton-pipelines-resolvers
spec:
replicas: 1
selector:
Expand All @@ -35,7 +35,7 @@ spec:
app: demoresolver
topologyKey: kubernetes.io/hostname
weight: 100
serviceAccountName: resolver
serviceAccountName: tekton-pipelines-resolvers
containers:
- name: controller
image: ko://github.com/tektoncd/pipeline/docs/resolver-template/cmd/demoresolver
Expand Down