tekton: make sure the git workingdir is not dirty… #5573
Conversation
tekton-robot
added
the
release-note
tekton-robot
added
the
kind/cleanup
tekton-robot
added
the
size/S
tekton-robot
added
the
approved
|
Would it make sense to have the release pipeline fail if its working dir is dirty, instead of silently pushing images that have |
good point, and I would say yes. let me update the PR to add this as well. |
… when building the released binaries/images. As of today, we are modifying the source and building. This means `knative.dev/pkg/changeset` will require the commit hash suffixed by `-dirty`. This can be a bit confusing the users as, well, this means the source is not really the source of truth of the binary :) This changes that: - it generates `.ko.yaml` in `/workspace` so that it's not in the git repository. It uses `KO_CONFIG_PATH` environment variable to force `ko` to use it. - it does the devel->version rewrite on generated yamls, so after the build is done. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
release-no-dirty
branch
from
0bbbf41
to
6f79354
Compare
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer, imjasonh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-v0.40.x |
|
@vdemeester: once the present PR merges, I will cherry-pick it on top of release-v0.40.x in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
@vdemeester: new pull request created: #5583 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
… when building the released binaries/images.
As of today, we are modifying the source and building. This means
knative.dev/pkg/changesetwill require the commit hash suffixed by-dirty. This can be a bit confusing the users as, well, this means the source is not really the source of truth of the binary :)This changes that:
.ko.yamlin/workspaceso that it's not in the git repository. It usesKO_CONFIG_PATHenvironment variable to forcekoto use it.Signed-off-by: Vincent Demeester [email protected]
/kind cleanup
/cc @imjasonh @mattmoor @afrittoli @abayer
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes