Fix paramValue Type for bundle conversion to resolver

[JeromeJu]

Changes

This commit adds the paramValue Type of string when converting the bundle to resolver from v1beta1 to v1.

Fixes: #5500
/kind bug

Thanks to the pointers from cc @lbernick

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• [n/a] Has Docs included if any changes are user facing
• [n/a] Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• [n/a] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• [n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[JeromeJu]

The following error in the webhook log after the current fix:

{"severity":"error","timestamp":"2022-10-11T14:11:13.433Z","logger":"tekton-pipelines-webhook.ConversionWebhook",
"caller":"controller/controller.go:566","message":"Reconcile error","commit":"e9e4cd6-dirty","knative.dev/traceid":"9d063b0f-806f-4015-aaea-
a8442d8e0423","knative.dev/key":"resolutionrequests.resolution.tekton.dev","duration":0.000091604,"error":"custom resource \"resolutionrequests.resolution.tekton.dev\" isn't configured for webhook 
conversion","stacktrace":"knative.dev/pkg/controller.(*Impl).handleErr\n\tknative.dev/[email protected]/controller/controller.go:566\nknative.dev/pkg/controller.
(*Impl).processNextWorkItem\n\tknative.dev/[email protected]/controller/controller.go:543\nknative.dev/pkg/controller.(*Impl).RunContext.func3\n\tknative.dev/[email protected]/controller/controller.go:491"}

[lbernick]

I think we'll also need to make this change for taskrefs, and it sounds like there is some additional work to address the new error you're observing in the webhook logs?

[JeromeJu]

I think we'll also need to make this change for taskrefs, and it sounds like there is some additional work to address the new error you're observing in the webhook logs?

Thanks Lee. Sorry, the Types for taskRef_conversion were previously there. For pipelineRef_conversion it is only the missing part that should be synced with the param conversion fix earlier :/
Yeah I was looking into in which line of the code this error came up.

[dibyom]

{"severity":"error","timestamp":"2022-10-11T14:11:13.433Z","logger":"tekton-pipelines-webhook.ConversionWebhook",
"caller":"controller/controller.go:566","message":"Reconcile error","commit":"e9e4cd6-dirty","knative.dev/traceid":"9d063b0f-806f-4015-aaea-
a8442d8e0423","knative.dev/key":"resolutionrequests.resolution.tekton.dev","duration":0.000091604,"error":"custom resource "resolutionrequests.resolution.tekton.dev" isn't configured for webhook
conversion","stacktrace":"knative.dev/pkg/controller.(*Impl).handleErr\n\tknative.dev/[email protected]/controller/controller.go:566\nknative.dev/pkg/controller.
(*Impl).processNextWorkItem\n\tknative.dev/[email protected]/controller/controller.go:543\nknative.dev/pkg/controller.(*Impl).RunContext.func3\n\tknative.dev/[email protected]/controller/controller.go:491"}

Looks like we have conversion enabled for resolution requests based on https://github.com/tektoncd/pipeline/blob/main/cmd/webhook/main.go#L191-L198

[JeromeJu]

Looks like this error persists in all cases, probably related with #5515 . It is not the scope of this commit but I could open up an issue if necessary cc @abayer

[abayer]

/approve

[vdemeester]

hum, seems like it needs a rebase 🤔

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS [abayer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JeromeJu]

Reopened, switching between laptops seem to have caused some issue rebasing.

/retest

[dibyom]

/lgtm