-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add taskrun.status.cloudEvents
to deprecation.md
#5937
Add taskrun.status.cloudEvents
to deprecation.md
#5937
Conversation
9931ac6
to
b0b3ca6
Compare
b0b3ca6
to
bc603fa
Compare
docs/pipeline-api.md
Outdated
<p>VerificationPolicy defines the Tekton resources and corresponding authorities to verify. | ||
The VerificationPolicy is used in trusted resources to store the public keys to verify | ||
Tekton resources.</p> | ||
<p>VerificationPolicy defines the rules to verify Tekton resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like our CI is not verifying that the pipeline api doc is getting generated correctly :(
Ideally this would be a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also noticed this earlier and I think @Yongxuanzhang had a fix in #5891.
I will add a standalone PR just for getting the pipeline-api.md up-to-date and also for PR granularity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added #5939.
This should also be in release notes. |
/reopen |
@JeromeJu: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bc603fa
to
1ed0ef7
Compare
/retest |
1 similar comment
/retest |
1ed0ef7
to
dad22df
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest |
Changes
This commit adds the taskrun.status.cloudEvents to deprecation.md.
The deprecation has already been proposed in TEP074 and is done in the migration to v1 as in the V1 CRD release,
this PR only serves to update the documentations.
/kind misc
cc @lbernick
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes