Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add taskrun.status.cloudEvents to deprecation.md #5937

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Add taskrun.status.cloudEvents to deprecation.md #5937

merged 1 commit into from
Jan 9, 2023

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Jan 3, 2023 •
edited
Loading

Changes

This commit adds the taskrun.status.cloudEvents to deprecation.md.
The deprecation has already been proposed in TEP074 and is done in the migration to v1 as in the V1 CRD release,
this PR only serves to update the documentations.

/kind misc
cc @lbernick

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • [n/a] Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jan 3, 2023
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 3, 2023
@JeromeJu JeromeJu force-pushed the update-cloudEvents-deprecation branch from 9931ac6 to b0b3ca6 Compare January 3, 2023 19:08
lbernick
lbernick reviewed Jan 3, 2023
View reviewed changes
pkg/apis/pipeline/v1beta1/taskrun_types.go Outdated Show resolved Hide resolved
docs/deprecations.md Show resolved Hide resolved
@JeromeJu JeromeJu force-pushed the update-cloudEvents-deprecation branch from b0b3ca6 to bc603fa Compare January 3, 2023 19:56
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 3, 2023
lbernick
lbernick approved these changes Jan 3, 2023
View reviewed changes
docs/pipeline-api.md Outdated
<p>VerificationPolicy defines the Tekton resources and corresponding authorities to verify.
The VerificationPolicy is used in trusted resources to store the public keys to verify
Tekton resources.</p>
<p>VerificationPolicy defines the rules to verify Tekton resources.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like our CI is not verifying that the pipeline api doc is getting generated correctly :(
Ideally this would be a separate PR

Copy link
Member Author

@JeromeJu JeromeJu Jan 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also noticed this earlier and I think @Yongxuanzhang had a fix in #5891.

I will add a standalone PR just for getting the pipeline-api.md up-to-date and also for PR granularity.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added #5939.

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2023
@lbernick
Copy link
Member

lbernick commented Jan 3, 2023

This should also be in release notes.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Jan 3, 2023
@JeromeJu JeromeJu mentioned this pull request Jan 3, 2023
Merged
3 tasks
@JeromeJu
Copy link
Member Author

JeromeJu commented Jan 4, 2023

/reopen

@tekton-robot tekton-robot reopened this Jan 4, 2023
@tekton-robot
Copy link
Collaborator

@JeromeJu: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JeromeJu JeromeJu force-pushed the update-cloudEvents-deprecation branch from bc603fa to 1ed0ef7 Compare January 4, 2023 18:49
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 4, 2023
@JeromeJu
Copy link
Member Author

JeromeJu commented Jan 4, 2023

/retest
flake: TestReconcile/success-with-cluster-task

1 similar comment
@JeromeJu
Copy link
Member Author

JeromeJu commented Jan 4, 2023

/retest
flake: TestReconcile/success-with-cluster-task

@JeromeJu JeromeJu force-pushed the update-cloudEvents-deprecation branch from 1ed0ef7 to dad22df Compare January 4, 2023 19:41
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 4, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lbernick,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dibyom
Copy link
Member

dibyom commented Jan 9, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2023
@JeromeJu
Copy link
Member Author

JeromeJu commented Jan 9, 2023

/retest
flake: #4643

@tekton-robot tekton-robot merged commit a51be25 into tektoncd:main Jan 9, 2023
@lbernick lbernick mentioned this pull request Jan 17, 2023
Closed
12 tasks
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@lbernick lbernick lbernick approved these changes

@jerop jerop Awaiting requested review from jerop

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JeromeJu @lbernick @tekton-robot @dibyom @vdemeester