Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch the Default Value of Feature Flag custom-task-version to v1beta1 #5961

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Switch the Default Value of Feature Flag custom-task-version to v1beta1 #5961

merged 1 commit into from
Jan 9, 2023

Conversation

XinruZhang
Copy link
Member

@XinruZhang XinruZhang commented Jan 5, 2023 •
edited
Loading

Changes

Switch the Default Value of Feature Flag custom-task-version to v1beta1

Prior to this PR, the feagure flag custom-task-version is default to v1alpha1, PipelineRun reconciler will create v1alpha1 Custom Task out of a PipelineTask defined in a Pipeline.

To support the migration story for Custom Task (see the migration doc), this PR switches the default value to v1beta1 in release v0.44.0 in order to make PipelineRun reconciler create v1beta1.CustomRun by default.

/kind cleanup
/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

The default value of `custom-task-version` is changed from `v1alpha1` to `v1beta1`, which means `v1beta1.CustomRun` will be created out of a Custom Task `PipelineTask` instead of `v1alpha1.Run`.

Deprecation Notice: `v1alpha1.Run` will be removed in release v0.47.0.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 5, 2023
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 5, 2023
@XinruZhang XinruZhang marked this pull request as draft January 5, 2023 20:43
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2023
lbernick
lbernick reviewed Jan 5, 2023
View reviewed changes
docs/pipelines.md Show resolved Hide resolved
docs/pipelines.md Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 5, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-using-tekton to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.1% 83.8% -2.3

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-using-tekton to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.1% 83.8% -2.3

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-using-tekton to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 86.1% 83.8% -2.3

@XinruZhang
Switch the Default Value of Feature Flag custom-task-version to `v1…
cdd0971 
…beta1`

Prior to this commit, the feagure flag `custom-task-version` is
default to `v1alpha1`, PipelineRun reconciler will create
`v1alpha1` Custom Task out of a PipelineTask defined in a Pipeline.

To support the migration story for Custom Task (see [the migration
doc](https://github.com/tektoncd/pipeline/blob/main/docs/migrating-v1alpha1.Run-to-v1beta1.CustomRun.md)),
this commit switches the default value to `v1beta1` in release v0.44.0
in order to make PipelineRun reconciler create `v1beta1.CustomRun`
by default.
@XinruZhang XinruZhang marked this pull request as ready for review January 6, 2023 19:01
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2023
@abayer
Copy link
Contributor

abayer commented Jan 9, 2023

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2023
@Yongxuanzhang
Copy link
Member

One question, why this pr is labeled as cleanup? It seems a change

@XinruZhang
Copy link
Member Author

One question, why this pr is labeled as cleanup? It seems a change

Good question, this is labeled as a cleanup PR of Custom Task Beta promotion -- remaining works of Custom Task Beta promotion while the beta Custom Task is ready to use, I'm open to suggestions :)

@lbernick
Copy link
Member

lbernick commented Jan 9, 2023

I think kind "misc" is most appropriate. I agree with Yongxuan that it's surprising for a "cleanup" PR to make functional changes.

@tekton-robot
Copy link
Collaborator

@XinruZhang: The label(s) kind/miscs cannot be applied, because the repository doesn't have them.

In response to this:

I think kind "misc" is most appropriate. I agree with Yongxuan that it's surprising for a "cleanup" PR to make functional changes.

SG!

/kind miscs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@XinruZhang
Copy link
Member Author

I think kind "misc" is most appropriate. I agree with Yongxuan that it's surprising for a "cleanup" PR to make functional changes.

SG!

/kind misc

@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 9, 2023
@Yongxuanzhang
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2023
@tekton-robot tekton-robot merged commit 585ac14 into tektoncd:main Jan 9, 2023
@XinruZhang XinruZhang mentioned this pull request Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick left review comments

@JeromeJu JeromeJu JeromeJu left review comments

@wlynch wlynch Awaiting requested review from wlynch

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@Yongxuanzhang Yongxuanzhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@XinruZhang @tekton-robot @abayer @Yongxuanzhang @lbernick @JeromeJu