Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0114: Remove Feature Flag enable-custom-tasks #5975

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

XinruZhang
Copy link
Member

@XinruZhang XinruZhang commented Jan 9, 2023

Changes

Custom Tasks have been promoted to the beta version, hence, enable-custom-tasks is not required anymore. This commit removes the feature flag.

/kind misc

fix #5861

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Removed the feature flag `enable-custom-tasks`.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jan 9, 2023
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 9, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 86.7% 87.3% 0.6
pkg/apis/pipeline/v1/pipeline_types.go 97.2% 97.2% -0.0
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.9% -0.0

Custom Tasks have been promoted to the beta version, hence,
enable-custom-tasks is not required anymore. This commit removes the
feature flag.
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/feature_flags.go 86.7% 87.3% 0.6
pkg/apis/pipeline/v1/pipeline_types.go 97.2% 97.2% -0.0
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.9% -0.0

@XinruZhang
Copy link
Member Author

/retest

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2023
@jerop jerop added this to the Pipelines v0.44 milestone Jan 10, 2023
@XinruZhang XinruZhang changed the title Remove Feature Flag enable-custom-tasks TEP-0114: Remove Feature Flag enable-custom-tasks Jan 10, 2023
@abayer
Copy link
Contributor

abayer commented Jan 10, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2023
@tekton-robot tekton-robot merged commit 892198b into tektoncd:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TEP-0114: Custom Tasks Beta - remove enable-custom-tasks
5 participants