Cleanup resources of ClusterTask

[JeromeJu]

Changes

This commit cleans up the unused functions for ClusterTask. It aims to keep the hygiene of the codebase and gets the repo ready for swapping the storage version to v1.

• Remove the GetClusterTask type which is not referenced anywhere in the codebase, this was first introduced in Add ClusterTask new CRD #312 and not used after the removal of v1alpha1 directory from ./pkg/reconciler/v1alpha1

/kind cleanup
part of #5979

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• [n/a] Has Docs included if any changes are user facing
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

remove `GetClusterTask` func

[JeromeJu]

This is an unreferenced type so it has not been regarded as dead code even though it was not used anywhere.

[JeromeJu]

/retest

[XinruZhang]

Thanks for the change @JeromeJu!

[Yongxuanzhang]

👍 I think release note is needed?

[JeromeJu]

👍 I think release note is needed?

I think we might not as this is not part of the API but the reconciler?

[Yongxuanzhang]

👍 I think release note is needed?

I think we might not as this is not part of the API but the reconciler?

It could be a using facing change, since it is public type?
https://pkg.go.dev/github.com/tektoncd/[email protected]/pkg/reconciler/taskrun/resources#GetClusterTask

[JeromeJu]

👍 I think release note is needed?

I think we might not as this is not part of the API but the reconciler?

It could be a using facing change, since it is public type? https://pkg.go.dev/github.com/tektoncd/[email protected]/pkg/reconciler/taskrun/resources#GetClusterTask

Makes sense! Updated, thanks for pointing this out.

[lbernick]

/approve

nit on the release note: the function is being removed, not deprecated ("deprecated" would make me think it's still usable)

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick, XinruZhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lbernick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Yongxuanzhang]

/lgtm