Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEP074] Remove Image pipelineResources #6002

Merged
merged 1 commit into from
Feb 24, 2023
Merged

[TEP074] Remove Image pipelineResources #6002

merged 1 commit into from
Feb 24, 2023

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Jan 17, 2023 •
edited
Loading

Changes

This commit removes the Image Resources support.

This PR removes github.com/tektoncd/pipeline/pkg/apis/resource/v1alpha1/image
the imagedigestexporter and the docs for image resources.It also removes the
integration tests helm_task_test andhermetic_taskrun_test as these tests
are testing building against image resources.

Removal of pipelineResources, as in #5967 has been broken up into removal of each resources according to small PRs.

Part of #5967
/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

action required: please migrate off of `image` `pipelineresources` as it is removed, please refer to the doc at https://github.com/tektoncd/pipeline/blob/main/docs/pipelineresources.md#replacing-an-image-resource
`imagedigestexporter` image will not be built nor maintained from now on

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 17, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.7% -0.3
pkg/reconciler/taskrun/resources/output_resource.go 89.1% 87.0% -2.2
pkg/reconciler/taskrun/taskrun.go 83.6% 83.9% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.1% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.7% -0.3
pkg/reconciler/taskrun/resources/output_resource.go 89.1% 87.0% -2.2
pkg/reconciler/taskrun/taskrun.go 83.6% 83.9% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.1% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.6% 97.9% -1.7
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.7% -0.3
pkg/reconciler/taskrun/resources/output_resource.go 89.1% 87.0% -2.2
pkg/reconciler/taskrun/taskrun.go 83.6% 83.9% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.1% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.6% 97.9% -1.7
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.7% -0.3
pkg/reconciler/taskrun/resources/output_resource.go 89.1% 87.0% -2.2
pkg/reconciler/taskrun/taskrun.go 83.6% 83.9% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.1% -0.4

@tekton-robot tekton-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. kind/misc Categorizes issue or PR as a miscellaneuous one. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Jan 18, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.6% 97.9% -1.7
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.7% -0.3
pkg/reconciler/taskrun/resources/output_resource.go 89.1% 87.0% -2.2
pkg/reconciler/taskrun/taskrun.go 83.6% 83.9% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.1% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.6% 97.9% -1.7
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.7% -0.3
pkg/reconciler/taskrun/resources/output_resource.go 89.1% 87.0% -2.2
pkg/reconciler/taskrun/taskrun.go 83.6% 83.9% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.1% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.6% 97.9% -1.7
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.7% -0.3
pkg/reconciler/taskrun/resources/output_resource.go 89.1% 87.0% -2.2
pkg/reconciler/taskrun/taskrun.go 83.6% 83.9% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.1% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.6% 97.9% -1.7
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.7% -0.3
pkg/reconciler/taskrun/resources/output_resource.go 89.1% 87.0% -2.2
pkg/reconciler/taskrun/taskrun.go 83.6% 83.9% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.1% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.6% 97.9% -1.7
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.7% -0.3
pkg/reconciler/taskrun/resources/output_resource.go 89.1% 87.0% -2.2
pkg/reconciler/taskrun/taskrun.go 83.6% 83.9% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.1% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.6% 97.9% -1.7
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.7% -0.3
pkg/reconciler/taskrun/resources/output_resource.go 89.1% 87.0% -2.2
pkg/reconciler/taskrun/taskrun.go 83.6% 83.9% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.1% -0.4

lbernick
lbernick approved these changes Jan 18, 2023
View reviewed changes
docs/resources.md Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2023
@JeromeJu JeromeJu mentioned this pull request Jan 19, 2023
Merged
6 tasks
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2023
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.6% 97.9% -1.7
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.7% -0.3
pkg/reconciler/taskrun/resources/output_resource.go 89.1% 87.0% -2.2
pkg/reconciler/taskrun/taskrun.go 83.6% 83.9% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.1% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.6% 97.9% -1.7
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 94.9% 94.7% -0.3
pkg/reconciler/taskrun/resources/output_resource.go 89.1% 87.0% -2.2
pkg/reconciler/taskrun/taskrun.go 83.6% 83.9% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.1% -0.4

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2023
@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2023
@JeromeJu JeromeJu force-pushed the rm-image-resources branch 2 times, most recently from a382bc3 to 3976cd6 Compare February 23, 2023 15:21
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.6% 97.9% -1.7
pkg/reconciler/taskrun/resources/output_resource.go 89.1% 87.0% -2.2
pkg/reconciler/taskrun/taskrun.go 84.5% 84.8% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.2% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go 99.6% 97.9% -1.7
pkg/reconciler/taskrun/resources/output_resource.go 89.1% 87.0% -2.2
pkg/reconciler/taskrun/taskrun.go 84.5% 84.8% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.2% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 84.5% 84.8% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.2% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 84.5% 84.8% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.2% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 84.5% 84.8% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.2% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 84.5% 84.8% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.2% -0.4

@JeromeJu JeromeJu requested review from lbernick and removed request for abayer and dibyom February 23, 2023 18:02
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 84.5% 84.8% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.2% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 84.5% 84.8% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.2% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 84.5% 84.8% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.2% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 84.5% 84.8% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.2% -0.4

@JeromeJu
Remove Image Resources
a47775f 
This commit removes the Image Resources support.
This PR removes
the imageDigestExporter and the docs for image resources.

It also removes the integration tests that test building
against image resources.
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 84.5% 84.8% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.2% -0.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/taskrun.go 84.5% 84.8% 0.3
pkg/reconciler/taskrun/validate_resources.go 98.5% 98.2% -0.4

@lbernick
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2023
@JeromeJu
Copy link
Member Author

/test pull-tekton-pipeline-beta-integration-tests

@tekton-robot tekton-robot merged commit 3ca8444 into tektoncd:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritidesai pritidesai pritidesai left review comments

@dibyom dibyom dibyom left review comments

@QuanZhang-William QuanZhang-William QuanZhang-William left review comments

@lbernick lbernick lbernick approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.46
Development

Successfully merging this pull request may close these issues.
8 participants
@JeromeJu @tekton-robot @lbernick @dibyom @afrittoli @vdemeester @pritidesai @QuanZhang-William