Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run codegen against latest main to update licenses and api doc #6189

Merged
merged 1 commit into from
Feb 22, 2023
Merged

run codegen against latest main to update licenses and api doc #6189

merged 1 commit into from
Feb 22, 2023

Conversation

Yongxuanzhang
Copy link
Member

@Yongxuanzhang Yongxuanzhang commented Feb 17, 2023 •
edited
Loading

Changes

This commit runs codegen against latest main to update licenses and api doc.

/kind misc

Signed-off-by: Yongxuan Zhang [email protected]

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Feb 17, 2023
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 17, 2023
afrittoli
afrittoli reviewed Feb 17, 2023
View reviewed changes
docs/pipeline-api.md Outdated
weight: 404
weight: 1000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change here?

@geriom ^^^

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely we should keep this as 404 (or anything other weight in the 400s).

Context: #6117

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is autogenerated, should I fix it manually?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may want to update the weight here

pipeline/hack/update-reference-docs.sh

Line 26 in 0b69945

sed -i".backup" '1s/^/<!--\n---\ntitle: Pipeline API\nlinkTitle: Pipeline API\nweight: 1000\n---\n-->\n\n/' ./docs/pipeline-api.md && rm docs/pipeline-api.md.backup

@geriom

@afrittoli
Copy link
Member

I wonder how is it possible that this delta is not caught by CI, it sounds like something is broken? @vdemeester wdyt?

@Yongxuanzhang
Copy link
Member Author

It may make sense to check the pipeline-api file. But I'm not sure about the licenses files

@JeromeJu
Copy link
Member

Wondering #6037 is not a blocker any more?

@vdemeester
Copy link
Member

I wonder how is it possible that this delta is not caught by CI, it sounds like something is broken? @vdemeester wdyt?

Good question 🤔

geriom
geriom suggested changes Feb 21, 2023
View reviewed changes
docs/pipeline-api.md Outdated
weight: 404
weight: 1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely we should keep this as 404 (or anything other weight in the 400s).

Context: #6117

lbernick
lbernick approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge but +1 on fixing CI so that this is checked

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2023
@geriom
Copy link
Contributor

geriom commented Feb 22, 2023

/lgtm

@tekton-robot
Copy link
Collaborator

@geriom: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dibyom dibyom mentioned this pull request Feb 22, 2023
Closed
@dibyom
Copy link
Member

dibyom commented Feb 22, 2023

/lgtm

Opened #6210

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2023
@Yongxuanzhang
Copy link
Member Author

that's weird, why the build fails but passed before?

@JeromeJu
Copy link
Member

JeromeJu commented Feb 22, 2023 •
edited
Loading

that's weird, why the build fails but passed before?

tektoncd/plumbing@50366b3 got in earlier and fixes #5771. I guess we should not need to restore register.go anymore

@Yongxuanzhang
run codegen against latest main to update licenses and api doc
4c93724 
This commit runs codegen against latest main to update licenses and api
doc.

Signed-off-by: Yongxuan Zhang [email protected]
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 22, 2023
@XinruZhang
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2023
@tekton-robot tekton-robot merged commit c53681d into tektoncd:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@geriom geriom geriom requested changes

@lbernick lbernick lbernick approved these changes

@vdemeester vdemeester Awaiting requested review from vdemeester

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@dibyom dibyom

@XinruZhang XinruZhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Yongxuanzhang @afrittoli @JeromeJu @vdemeester @tekton-robot @geriom @dibyom @XinruZhang @lbernick