Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Removed Table for deprecation.md #6209

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Feb 22, 2023

Changes

This commit updates the deprecation.md by creating a 'removed' table to
distinguish the features that are removed or being deprecated.

/kind documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [n/a] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 22, 2023
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2023
docs/deprecations.md Outdated Show resolved Hide resolved
docs/deprecations.md Show resolved Hide resolved
docs/deprecations.md Outdated Show resolved Hide resolved
docs/deprecations.md Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 22, 2023
@JeromeJu JeromeJu force-pushed the update-deprecation branch 2 times, most recently from 100467a to 44b222a Compare February 23, 2023 16:37
@JeromeJu JeromeJu changed the title Create deprecated table for deprecation.md Create Removed Table for deprecation.md Feb 23, 2023
@JeromeJu JeromeJu marked this pull request as ready for review February 23, 2023 19:41
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 23, 2023
@JeromeJu
Copy link
Member Author

cc @pritidesai @wlynch

docs/deprecations.md Outdated Show resolved Hide resolved
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023
@JeromeJu JeromeJu force-pushed the update-deprecation branch 2 times, most recently from d519b8a to 7651f84 Compare March 1, 2023 16:09
@JeromeJu JeromeJu requested review from dibyom and removed request for pritidesai March 1, 2023 16:09
docs/deprecations.md Outdated Show resolved Hide resolved
@Yongxuanzhang
Copy link
Member

I thought Earliest Date or Release of Removal is used to record which release we remove the deprecated features. Why do we need a separate table?

@JeromeJu
Copy link
Member Author

JeromeJu commented Mar 3, 2023

I thought Earliest Date or Release of Removal is used to record which release we remove the deprecated features. Why do we need a separate table?

Good question! This came from the reason that #6206 (comment) suggests we should not remove deprecated fields from deprecation table. While EOL in the above table indicates the time that we could remove it, the new table targets to note down the time it was actually removed and the latest supporting LTS for that feature.

@vdemeester
Copy link
Member

@abayer @afrittoli @bobcatfish @jerop @lbernick please take a look at the PR to take a decision on it 👼🏼

docs/deprecations.md Outdated Show resolved Hide resolved
@JeromeJu JeromeJu force-pushed the update-deprecation branch 2 times, most recently from 37ca0b3 to 5a96e88 Compare March 8, 2023 17:48
This commit updates the deprecation.md by creating a 'removed' table to
distinguish the features that are removed or being deprecated.
@lbernick
Copy link
Member

lbernick commented Mar 8, 2023

/retest
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2023
@JeromeJu
Copy link
Member Author

JeromeJu commented Mar 9, 2023

/retest

@JeromeJu JeromeJu closed this Mar 9, 2023
@JeromeJu JeromeJu reopened this Mar 9, 2023
@tekton-robot tekton-robot merged commit 358501b into tektoncd:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants