-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEP-114] Remove the feature flag custom-task-version to stop supporting v1alpha1 Run #6499
[TEP-114] Remove the feature flag custom-task-version to stop supporting v1alpha1 Run #6499
Conversation
Skipping CI for Draft Pull Request. |
/test all |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
f6a89c9
to
1915220
Compare
/test all |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
1915220
to
eee49f3
Compare
/assign @jerop |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
eee49f3
to
08107c8
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Yongxuanzhang!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we also need to remove the alpha custom task controller? or would that be in the follow-up PR removing v1alpha1 custom task? https://github.com/tektoncd/pipeline/tree/main/test/custom-task-ctrls/wait-task-alpha
docs/pipelines.md
Outdated
@@ -1618,7 +1618,8 @@ no `runAfter` can be specified in `finally` tasks. | |||
|
|||
## Using Custom Tasks | |||
|
|||
Custom Tasks have been promoted from `v1alpha1` to `v1beta1`. Starting from `v0.43.0`, Pipeline Controller is able to create either `v1alpha1` or `v1beta1` Custom Task gated by a feature flag `custom-task-version`, defaulting to `v1beta1`. You can set `custom-task-version` to `v1alpha1` or `v1beta1` to control which version to create. | |||
Custom Tasks have been promoted from `v1alpha1` to `v1beta1`. Starting from `v0.43.0` to `v0.46.0`, Pipeline Controller is able to create either `v1alpha1` or `v1beta1` Custom Task gated by a feature flag `custom-task-version`, defaulting to `v1beta1`. You can set `custom-task-version` to `v1alpha1` or `v1beta1` to control which version to create. | |||
Starting from `v0.47.0`, feature flag `custom-task-version` is removed and only `v1beta1` Custom Task will be supported. | |||
|
|||
We'll remove the flag `custom-task-version` and the entire alpha Custom Task in release v0.47.0 (tracked in the issue #5837). See the [migration doc](migrating-v1alpha1.Run-to-v1beta1.CustomRun.md) for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence needs an update
Yes I will remove it in next PR. |
This commit closes tektoncd#5837. It removes the feature flag custom-task-version to stop supporting v1alpha1.Run as planed in TEP-114. There will be a separate PR to remove the v1alpha1.Run tracking by tektoncd#6498. Signed-off-by: Yongxuan Zhang [email protected]
08107c8
to
f42207b
Compare
/kind cleanup |
@Yongxuanzhang: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-kind feature |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/lgtm |
Changes
This commit closes #5837. It removes the feature flag custom-task-version to stop supporting v1alpha1.Run as planed in TEP-114. There will be a separate PR to remove the v1alpha1.Run tracking by #6498.
/kind feature
Signed-off-by: Yongxuan Zhang [email protected]
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes