Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0089: Refactor setting of "enforce-nonfalsifiability" feature flag #6527

Merged
merged 1 commit into from
Apr 14, 2023

Commits on Apr 13, 2023

  1. TEP-0089: Refactor setting of "enforce-nonfalsifiability" feature flag

    In this change, we refactor the code for setting "enforce-nonfalsifiability"
    feature flag to make it easier to understand, and consistent with the rest
    of the code. This refactor will make it easier to promote the feature to beta,
    and beyond.
    
    This change also documents that `enable-api-fields` has to be set to `"alpha"`
    for non-falsifiability to work.
    
    This commit also includes a change to `TestNewFeatureFlagsConfigMapErrors` to
    check the exact error, instead of just checking that there was an error. This
    is useful in validating that both errors that can be triggered while setting
    the "enforce-nonfalsifiability" feature flag are tested.
    jerop committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    f01ee2e View commit details
    Browse the repository at this point in the history