Update pipelineTasks in Release-Pipeline to use Git Resolver #6565

jsminem · 2023-04-19T21:41:19Z

Update pipelineTasks in release-pipeline.yaml file
Fixes #6379
/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

tekton-robot · 2023-04-19T21:41:28Z

Hi @jsminem. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afrittoli · 2023-04-19T23:02:16Z

/ok-to-test

afrittoli

Thank you for your PR.
The only task hosted on pipeline side is the publish one.
Everything else comes from the catalog or the plumbing repo.
We could still switch to remote resolution, but the revision is not the pipeline one.
For catalog ones, I would suggest to use the bundles, since the version of the task is then visible in the tag.

afrittoli · 2023-04-19T23:10:40Z

tekton/release-pipeline.yaml

+        resolver: git
+        params:
+        - name: repo
+          value: pipeline
+        - name: org
+          value: tektoncd
+        - name: revision
+          value: $(params.gitRevision)
+        - name: pathInRepo
+          value: tekton/publish.yaml


The git-clone task is defined in the catalog, not in the pipeline repo.
We could either pull it from there with the git resolver and pin it to a revision that matches the current sha of the tip of the main branch. Alternatively we could use the bundle remote resolver and consume it, as we do for in the plumbing repo, from the bundles published to grc.io - see https://github.com/tektoncd/plumbing/blob/2b2d5d06c8ffd885945feae76318ac8a153b3c8d/tekton/ci/jobs/tekton-golang-tests.yaml#L37-L44 for an example

Thanks so much Andrea! This was very helpful.
As suggested, I've used the first approach to update prerelease-checks task in the plumbing repo and bundles for the tasks in the catalog repo. Any feedback would be greatly appreciated! 😊🙏

Should I also include package in params? Like in the example for bundles, https://github.com/tektoncd/catalog?

params: - name: package value: github.com/tektoncd/pipeline

afrittoli · 2023-04-19T23:14:59Z

tekton/release-pipeline.yaml

@@ -66,7 +76,16 @@ spec:
    - name: precheck
      runAfter: [git-clone]
      taskRef:
-        name: prerelease-checks


The name here should not be deleted

@afrittoli I'm curious why you suggested restoring taskRef.name? I don't think we allow it in combination with taskRef.resolver. Separately, do you think we could add tests verifying the release pipeline configuration is valid, in order to catch issues like this?

afrittoli · 2023-04-19T23:17:26Z

tekton/release-pipeline.yaml

+        resolver: git
+        params:
+        - name: repo
+          value: pipeline


The prerelease-check comes from the plumbing repo. It is deployed together with the pipeline to the cluster when the pipeline definition is installed, so maybe we don't need to change this for now.
If you wanted to use remote resolution here, this is the URL https://github.com/tektoncd/plumbing/blob/main/tekton/resources/release/base/prerelease_checks.yaml

tekton/release-pipeline.yaml

jsminem · 2023-04-20T00:21:14Z

Thanks so much for the feedback! 🙏

afrittoli · 2023-04-20T06:17:49Z

/ok-to-test

…t resolver update release pipeline to use remote resolution using bundles and git resolver update release pipeline to use remote resolution using bundles and git resolver update release pipeline to use remote resolution using bundles and git resolver update release pipeline to use git resolver update release pipeline to use git resolver update release pipeline to use git resolver update release pipeline update release pipeline update release pipeline to use remote resolution using bundles and git resolver

afrittoli

Thank you for all the updates @jsminem, the PR looks good now!
According to "tide", you may need to rebase it though
/approve

afrittoli · 2023-06-09T13:56:12Z

/cc @lbernick @vdemeester FYI

tekton-robot · 2023-06-09T13:56:15Z

@afrittoli: GitHub didn't allow me to request PR reviews from the following users: FYI.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @lbernick @vdemeester FYI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2023-06-13T12:55:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [afrittoli,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jerop

/lgtm

tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Apr 19, 2023

tekton-robot requested review from afrittoli and vdemeester April 19, 2023 21:41

tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 19, 2023

tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 19, 2023

afrittoli reviewed Apr 19, 2023

View reviewed changes

jsminem marked this pull request as draft April 20, 2023 00:24

tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 20, 2023

jsminem force-pushed the update-release-pipeline branch from 4ef3f3b to aa7ba1b Compare April 20, 2023 13:36

jsminem closed this Apr 21, 2023

jsminem reopened this Apr 29, 2023

tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2023

jsminem force-pushed the update-release-pipeline branch from b29cf0e to c73bdfb Compare April 29, 2023 14:53

jsminem requested a review from afrittoli April 29, 2023 14:57

jsminem marked this pull request as ready for review April 29, 2023 14:58

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2023

tekton-robot requested a review from lbernick April 29, 2023 14:59

jsminem force-pushed the update-release-pipeline branch 3 times, most recently from 5ea3497 to ecf0d9f Compare April 29, 2023 16:45

jerop mentioned this pull request May 24, 2023

Update pipeline release cheatsheet #6712

Closed

3 tasks

tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 26, 2023

jsminem force-pushed the update-release-pipeline branch from 7f54dbe to c6101c8 Compare May 26, 2023 21:13

tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 26, 2023

jsminem force-pushed the update-release-pipeline branch from 597f8eb to 3d55599 Compare May 26, 2023 21:26

afrittoli reviewed Jun 9, 2023

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2023

vdemeester approved these changes Jun 13, 2023

View reviewed changes

jerop reviewed Jun 20, 2023

View reviewed changes

tekton-robot assigned jerop Jun 20, 2023

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2023

tekton-robot merged commit c802069 into tektoncd:main Jun 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update pipelineTasks in Release-Pipeline to use Git Resolver #6565

Update pipelineTasks in Release-Pipeline to use Git Resolver #6565

jsminem commented Apr 19, 2023

tekton-robot commented Apr 19, 2023

afrittoli commented Apr 19, 2023

afrittoli left a comment

afrittoli Apr 19, 2023

jsminem Apr 29, 2023 •

edited

Loading

jsminem Apr 29, 2023

afrittoli Apr 19, 2023

lbernick Jun 9, 2023

afrittoli Apr 19, 2023

jsminem commented Apr 20, 2023

afrittoli commented Apr 20, 2023

afrittoli left a comment

afrittoli commented Jun 9, 2023

tekton-robot commented Jun 9, 2023

tekton-robot commented Jun 13, 2023

jerop left a comment

Update pipelineTasks in Release-Pipeline to use Git Resolver #6565

Update pipelineTasks in Release-Pipeline to use Git Resolver #6565

Conversation

jsminem commented Apr 19, 2023

Submitter Checklist

Release Notes

tekton-robot commented Apr 19, 2023

afrittoli commented Apr 19, 2023

afrittoli left a comment

Choose a reason for hiding this comment

afrittoli Apr 19, 2023

Choose a reason for hiding this comment

jsminem Apr 29, 2023 • edited Loading

Choose a reason for hiding this comment

jsminem Apr 29, 2023

Choose a reason for hiding this comment

afrittoli Apr 19, 2023

Choose a reason for hiding this comment

lbernick Jun 9, 2023

Choose a reason for hiding this comment

afrittoli Apr 19, 2023

Choose a reason for hiding this comment

jsminem commented Apr 20, 2023

afrittoli commented Apr 20, 2023

afrittoli left a comment

Choose a reason for hiding this comment

afrittoli commented Jun 9, 2023

tekton-robot commented Jun 9, 2023

tekton-robot commented Jun 13, 2023

jerop left a comment

Choose a reason for hiding this comment

jsminem Apr 29, 2023 •

edited

Loading