Add Unit Tests for Array Results using [] notation #6577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/bug
jerop
reviewed
Apr 25, 2023
jerop
reviewed
Apr 25, 2023
jerop
reviewed
Apr 25, 2023
EmmaMunley
force-pushed
the
add-test-coverage-arrays
branch
2 times, most recently
from
ad46bff
to
800c8e4
Compare
jerop
reviewed
Apr 26, 2023
EmmaMunley
force-pushed
the
add-test-coverage-arrays
branch
2 times, most recently
from
3f488e8
to
2b83efd
Compare
jerop
reviewed
Apr 26, 2023
EmmaMunley
force-pushed
the
add-test-coverage-arrays
branch
from
2b83efd
to
bf5ce34
Compare
lbernick
reviewed
Apr 26, 2023
EmmaMunley
force-pushed
the
add-test-coverage-arrays
branch
from
bf5ce34
to
998e2cb
Compare
lbernick
reviewed
Apr 27, 2023
EmmaMunley
force-pushed
the
add-test-coverage-arrays
branch
5 times, most recently
from
ba3080c
to
4fd1029
Compare
lbernick
approved these changes
Apr 28, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
EmmaMunley
force-pushed
the
add-test-coverage-arrays
branch
2 times, most recently
from
b0eda73
to
04aabab
Compare
jerop
reviewed
Apr 28, 2023
Comment on lines
+186
to
+192
| // getTaskRunsForPipelineTask returns the set of TaskRuns associated with the input PipelineRun and PipelineTask | ||
| // It will fatal the test if an error occurred. | ||
| func getTaskRunsForPipelineTask(ctx context.Context, t *testing.T, clients test.Clients, namespace string, prName string, ptLabel string) map[string]*v1beta1.TaskRun { | ||
| t.Helper() | ||
| labelSelector := pipeline.PipelineRunLabelKey + "=" + prName + "," + pipeline.PipelineTaskLabelKey + "=" + ptLabel | ||
| return getTaskRuns(ctx, t, clients, namespace, labelSelector) | ||
| } |
There was a problem hiding this comment.
nice!!
it'd be amazing if you could clean up the other tests to use this function in a follow up PR 🙏🏾
jerop
reviewed
Apr 28, 2023
EmmaMunley
force-pushed
the
add-test-coverage-arrays
branch
from
04aabab
to
d4cf0f9
Compare
This commit adds test coverage for a pipeline task that emit an array of results and test string replacements from the array of results using indexing. This addresses issue: tektoncd#6574.
EmmaMunley
force-pushed
the
add-test-coverage-arrays
branch
from
d4cf0f9
to
332fdb2
Compare
|
/lgtm |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds test coverage for a pipeline task that emits an array of results and with string replacements from the array of results using indexing. This closes #6574. It also refactors
getTaskRunsForPipelineRun()to filter by PT label/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes