Fix conversion of non-object results declared in Tasks #6606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, conversion between v1beta1 and v1 Tasks would create an empty map for task.spec.results.properties, even if the Task result was not an object result. Currently, if Task result properties are a nil map, the result is treated as a string result. If Task result properties are an empty map, the result is treated as an object result. This commit only updates the conversion logic of Task results to match the conversion logic of task params; it creates a non-nil Properties map only if Properties was already non-nil. Addressing the differences in how nil vs empty Properties are treated will be handled in a separate commit.
tekton-robot
added
release-note
4 tasks
dibyom
approved these changes
May 1, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, conversion between v1beta1 and v1 Tasks would create an empty map for task.spec.results.properties, even if the Task result was not an object result.
Currently, if Task result properties are a nil map, the result is treated as a string result. If Task result properties are an empty map, the result is treated as an object result. This commit only updates the conversion logic of Task results to match the conversion logic of task params; it creates a non-nil Properties map only if Properties was already non-nil.
Addressing the differences in how nil vs empty Properties are treated will be handled in a separate commit (#6605).
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes