-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor validation functions for indexing into array params #6642
Conversation
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
This commit refactors validation functions for Tasks and Pipelines that index into array params by creating helper functions for getting all indexing references to array params in Task and Pipeline specs. No functional changes expected from this commit.
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
// from parameters, workspaces, and when expressions defined in the Pipeline's Tasks and Finally Tasks. | ||
// For example, if a Task in the Pipeline has a parameter with a value "$(params.array-param-name[1])", | ||
// this would be one of the strings returned. | ||
func (ps *PipelineSpec) GetIndexingReferencesToArrayParams() sets.String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason why this function is exported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These exported functions are used in the reconciler in #6617. I would un-export them for this PR, but some of the task validation tests use package v1_test, and I don't think it's worth it to change the package name and un-export these functions only to export them in the follow-up PR. it's not a perfect split, but I'm just trying to chip away at 6617 as much as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah good to know it is (or will be) used in the reconciler, sgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
flake: TestExamples/v1/taskruns/authenticating-git-commands |
This commit refactors validation functions for Tasks and Pipelines that index into array params by creating helper functions for getting all indexing references to array params in Task and Pipeline specs. No functional changes expected from this commit.
Refactoring to split out non-functional changes from #6617.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes