Refactor test cases for remote TaskRef #6778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
JeromeJu
force-pushed
the
remote-taskref-refactor-testcase
branch
from
fe28e3a
to
634d6c7
Compare
|
/kind cleanup |
tekton-robot
added
the
kind/cleanup
JeromeJu
force-pushed
the
remote-taskref-refactor-testcase
branch
from
634d6c7
to
27672e4
Compare
tekton-robot
added
size/M
lbernick
reviewed
Jun 6, 2023
tekton-robot
added
the
needs-rebase
JeromeJu
force-pushed
the
remote-taskref-refactor-testcase
branch
from
27672e4
to
244a678
Compare
tekton-robot
removed
the
needs-rebase
JeromeJu
force-pushed
the
remote-taskref-refactor-testcase
branch
from
244a678
to
baf2f1d
Compare
JeromeJu
force-pushed
the
remote-taskref-refactor-testcase
branch
from
baf2f1d
to
d6677c7
Compare
tekton-robot
added
size/L
lbernick
approved these changes
Jun 6, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This commit refactors the test cases for taskRef_Test by: - separate the TestGetTaskFunc for local, resolution and bundle tests since part of the syntax has deprecated in v1beta1 and diverged when we are going to move to v1. - creats a separated test class TestGetTaskFunc_Bundle since there would be no field in bundle resolvers - remove the test cases regarding remote tasks ie. remote task without defaults in TestGetTaskFunc to TestGetTaskFunc_Remoteresolution and renames it to TestGetTaskFunc_Local - change the test cases where bundle resolver is used for the remote clusterTask, which does not make sense as a functionality given it is valid
JeromeJu
force-pushed
the
remote-taskref-refactor-testcase
branch
from
d6677c7
to
f17c1de
Compare
|
/retest |
|
/lgtm |
|
/test pull-tekton-pipeline-beta-integration-tests |
7 tasks
JeromeJu
added a commit
to JeromeJu/pipeline
that referenced
this pull request
Jun 9, 2023
This commit refactors the test cases related with remote pipelineRef, which separates the original TestGetTaskFunc to local, bundle and remote due to the syntax of v1beta1 bundle has been deprecated in v1 and replaced with the bundle resolver. This is similar to the cleanup for TaskRef in tektoncd#6778
4 tasks
JeromeJu
added a commit
to JeromeJu/pipeline
that referenced
this pull request
Jun 9, 2023
This commit refactors the test cases related with remote pipelineRef, which separates the original TestGetTaskFunc to local, bundle and remote due to the syntax of v1beta1 bundle has been deprecated in v1 and replaced with the bundle resolver. This is similar to the cleanup for TaskRef in tektoncd#6778
JeromeJu
added a commit
to JeromeJu/pipeline
that referenced
this pull request
Jun 9, 2023
This commit refactors the test cases related with remote pipelineRef, which separates the original TestGetTaskFunc to local, bundle and remote due to the syntax of v1beta1 bundle has been deprecated in v1 and replaced with the bundle resolver. This is similar to the cleanup for TaskRef in tektoncd#6778
JeromeJu
added a commit
to JeromeJu/pipeline
that referenced
this pull request
Jun 9, 2023
This commit refactors the test cases related with remote pipelineRef, which separates the original TestGetTaskFunc to local, bundle and remote due to the syntax of v1beta1 bundle has been deprecated in v1 and replaced with the bundle resolver. This is similar to the cleanup for TaskRef in tektoncd#6778
tekton-robot
pushed a commit
that referenced
this pull request
Jun 12, 2023
This commit refactors the test cases related with remote pipelineRef, which separates the original TestGetTaskFunc to local, bundle and remote due to the syntax of v1beta1 bundle has been deprecated in v1 and replaced with the bundle resolver. This is similar to the cleanup for TaskRef in #6778
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit refactors the test cases for taskRef_Test by:
since part of the syntax has deprecated in v1beta1 and diverged when
we are going to move to v1.
be no
taskref.namefield in bundle resolversdefaults in TestGetTaskFunc to TestGetTaskFunc_Remoteresolution and
renames it to TestGetTaskFunc_Local
clusterTask, which does not make sense as a functionality given it is valid
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes