[release-v0.44.x] Fix v1beta1 pipelineref bundle conversion to resolver

[JeromeJu]

This commit fixes the bundle conversion for PipelineRef which should be converting to the bundle Resolver with a Pipeline kind. It also adds the conversion integration tests for the bundle logics to prevent such error. It extracts the setup for bundle and makes it into a helper function.

Changes

This is a cherry-pick of #6791

This commit fixes the bundle conversion for PipelineRef which should be converting to the bundle Resolver with a Pipeline kind. It also adds the conversion integration tests for the bundle logics to prevent such error. It extracts the setup for bundle and makes it into a helper function.

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• [n/a] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• [n/a] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• [n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

bug fix: bundle resolver type param value for pipelineRef conversion

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	96.8%	94.6%	-2.2

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	96.8%	94.6%	-2.2

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	96.8%	94.6%	-2.2

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	96.8%	94.6%	-2.2

[vdemeester]

/retest
/approve
/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vdemeester]

/retest

[vdemeester]

    conversion_test.go:1290: -want, +got:   &v1.TaskRun{
          }
    conversion_test.go:1298: -want, +got:   &v1beta1.TaskRun{
          }

This is a weird error on the alpha e2e tests.. TestBundleCreation 🤔

[lbernick]

@JeromeJu curious why there are two commits here? it looks like this PR is just meant to be a cherry-pick of the first commit; curious why the changes in the second commit are needed?

[vdemeester]

/retest

One last re-test to see if it's a flaky or not 🤔

[JeromeJu]

/retest

One last re-test to see if it's a flaky or not 🤔

This happened because the cmpopts.ignoreFields for release note annotations could only work if there is an annotations: {} apparent in the yaml. It didn't fail for me at local previously though 🤔 which had been weird.

[vdemeester]

/lgtm

[JeromeJu]

curious why there are two commits here? it looks like this PR is just meant to be a cherry-pick of the first commit; curious why the changes in the second commit are needed?

sorry was in the middle of squashing them. didn't manage to push the squash PR yet since last Friday I was stuck with some weird failure with deploying the v0.44.x branch (all fixed now though).

And the changes made in 2nd commit happened because we didn't have provenance for feature flags in place at that time.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	96.8%	94.6%	-2.2

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	96.8%	94.6%	-2.2