-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add apiVersion to trustedResources helper #6815
Conversation
The following is the coverage report on the affected files.
|
be24f90
to
2517acd
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
2517acd
to
1d346dd
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
1d346dd
to
9a12ab9
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if err != nil { | ||
return nil, err | ||
// GetSignedPipeline signed the given pipeline and rename it with given name and apiVersion | ||
func GetSignedPipeline(unsigned runtime.Object, signer signature.Signer, name, apiVersion string) (runtime.Object, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one disadvantage of merging 2 helper functions is that we need to do type assert for the returned obj
9a12ab9
to
d661c7d
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
d661c7d
to
29f1138
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
29f1138
to
a306cd4
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
a306cd4
to
fe742de
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
fe742de
to
34889b0
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This commit adds the apiVersion to the trustedResources helper which now allows the getSignedTask and etc helpers to return verified CRDs with the accepted apiVersions. This could help avoid confusions when we are adding v1 CRDs to be verified in the test cases.
34889b0
to
fba9a5a
Compare
New changes are detected. LGTM label has been removed. |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
@JeromeJu: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Hello @JeromeJu - is this something you're still pursuing? |
Changes
This commit adds the apiVersion to the trustedResources helper which now allows the getSignedTask and etc helpers to return verified CRDs with the accepted apiVersions. This could help avoid confusions when we are adding v1 CRDs to be verified in the test cases.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes