TEP-0135: implement per-pipelinerun coscheduling #6819

QuanZhang-William · 2023-06-12T21:10:45Z

Part of #6740. TEP-0135 introduces a feature that allows a cluster operator to ensure that all of a PipelineRun's pods are scheduled to the same node.

This commit implements the pipelineruns scheduling mode, where all the pods of a PipelineRun are scheduled to the same node. This commit renames the current createOrUpdateAffinityAssistants function to createOrUpdateAffinityAssistantsPerWorkspace, and adds a new function createOrUpdateAffinityAssistantsPerPipelineRun for the pipelineruns scheduling mode (with some refactoring).

There is no functionality change of the existing createOrUpdateAffinityAssistants function. The createOrUpdateAffinityAssistantsPerPipelineRun function is implemented, but not used. The usage of the createOrUpdateAffinityAssistantsPerPipelineRun function will be added in the followup PRs.

/kind feature

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

tekton-robot · 2023-06-12T21:15:54Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	95.5%	96.6%	1.0

tekton-robot · 2023-06-12T21:19:03Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	95.5%	96.6%	1.0

tekton-robot · 2023-06-13T14:18:13Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	95.5%	96.6%	1.0

tekton-robot · 2023-06-13T14:20:52Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	95.5%	96.6%	1.0

pkg/reconciler/pipelinerun/affinity_assistant.go

lbernick · 2023-06-14T15:05:29Z

pkg/reconciler/pipelinerun/affinity_assistant_test.go

+				t.Errorf("unexpected error when retrieving StatefulSet which expects nil: %v", err)
+			}
+
+			// TODO: test cleanupAffinityAssistants for coscheduling-pipelinerun mode when fully implemented


is there a way to implement support for cleanup within this PR?

I'm planning to implement the cleanup logic for coscheduling-pipelinerun mode in a separate PR to make review easier. I have added an todo to the cleanupAffinityAssistants function

tekton-robot · 2023-06-15T20:15:15Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.8%	97.2%	-0.6

tekton-robot · 2023-06-15T20:16:48Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.8%	97.2%	-0.6

tekton-robot · 2023-06-15T20:28:07Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.8%	98.1%	0.4

tekton-robot · 2023-06-15T20:31:23Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.8%	98.1%	0.4

tekton-robot · 2023-06-15T22:04:12Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.8%	98.1%	0.4

tekton-robot · 2023-06-15T22:08:39Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.8%	98.1%	0.4

tekton-robot · 2023-06-16T15:09:54Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.8%	98.1%	0.4

tekton-robot · 2023-06-16T15:12:06Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.8%	98.1%	0.4

pkg/reconciler/pipelinerun/affinity_assistant.go

tekton-robot · 2023-06-22T15:23:56Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.8%	98.2%	0.4

tekton-robot · 2023-06-22T15:27:03Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.8%	98.2%	0.4

QuanZhang-William · 2023-06-26T21:04:19Z

As discussed in the API WG, we will revert the PVC creation behavior for coschedule per workspace mode.

/hold

QuanZhang-William · 2023-06-27T19:54:00Z

We have some ongoing discussion around the PVC deletion behavior in this thread #6741 (comment). However, I think the discussion is not really relevant to this PR and we can patch the PVC deletion behavior in the followup PRs based on the discussion.

/cc @lbernick @pritidesai

API WG discussion summarized: #6741 (comment)
This PR just adds per-pipelinerun mode implementation which can be merged separately, I will send out follow-up PR to revert the per-workspace mode implementation as described: #6741 (comment)

Part of [tektoncd#6740][tektoncd#6740]. [TEP-0135][tep-0135] introduces a feature that allows a cluster operator to ensure that all of a PipelineRun's pods are scheduled to the same node. This commit implements the `pipelineruns` scheduling mode, where all the `pods` of a `PipelineRun` are scheduled to the same node. This commit renames the current `createOrUpdateAffinityAssistants` function to `createOrUpdateAffinityAssistantsPerWorkspace`, and adds a new function `createOrUpdateAffinityAssistantsPerPipelineRun` for the `pipelineruns` scheduling mode (with some refactoring). There is no functionality change of the existing `createOrUpdateAffinityAssistants` function. The `createOrUpdateAffinityAssistantsPerPipelineRun` function is implemented, but not used. The usage of the `createOrUpdateAffinityAssistantsPerPipelineRun` function will be added in the followup PRs. /kind feature [tektoncd#6740]: tektoncd#6740 [tep-0135]: https://github.com/tektoncd/community/blob/main/teps/0135-coscheduling-pipelinerun-pods.md

QuanZhang-William · 2023-06-28T18:13:45Z

#6790 is merged.
/hold cancel

tekton-robot · 2023-06-28T18:18:46Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.8%	98.2%	0.4

tekton-robot · 2023-06-28T18:21:13Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	97.8%	98.2%	0.4

QuanZhang-William · 2023-06-28T18:56:49Z

/test pull-tekton-pipeline-alpha-integration-tests

Yongxuanzhang

/lgtm

Part of [tektoncd#6740]. [TEP-0135][tep-0135] introduces a feature that allows a cluster operator to ensure that all of a PipelineRun's pods are scheduled to the same node. This commit consumes the functions added in [tektoncd#6819] and implements end to end support of `Coschedule:PipelineRuns` coschedule mode, where all the `PipelineRun pods` are scheduled to the same node. /kind feature [tektoncd#6819]: tektoncd#6819 [tektoncd#6740]: tektoncd#6740 [tep-0135]: https://github.com/tektoncd/community/blob/main/teps/0135-coscheduling-pipelinerun-pods.md

Part of [tektoncd#6740]. [TEP-0135][tep-0135] introduces a feature that allows a cluster operator to ensure that all of a PipelineRun's pods are scheduled to the same node. This commit consumes the functions added in [tektoncd#6819] to implement end to end support of `Coschedule:PipelineRuns` where all the `PipelineRun pods` are scheduled to the same node, and the `Coschedule:isolate-pipelinerun` coschedule modes where only 1 PipelineRun is allowed to run in a node at the same time. /kind feature [tektoncd#6819]: tektoncd#6819 [tektoncd#6740]: tektoncd#6740 [tep-0135]: https://github.com/tektoncd/community/blob/main/teps/0135-coscheduling-pipelinerun-pods.md

Part of [#6740]. [TEP-0135][tep-0135] introduces a feature that allows a cluster operator to ensure that all of a PipelineRun's pods are scheduled to the same node. This commit consumes the functions added in [#6819] to implement end to end support of `Coschedule:PipelineRuns` where all the `PipelineRun pods` are scheduled to the same node, and the `Coschedule:isolate-pipelinerun` coschedule modes where only 1 PipelineRun is allowed to run in a node at the same time. /kind feature [#6819]: #6819 [#6740]: #6740 [tep-0135]: https://github.com/tektoncd/community/blob/main/teps/0135-coscheduling-pipelinerun-pods.md

tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesnt merit a release note. labels Jun 12, 2023

tekton-robot requested review from afrittoli and vdemeester June 12, 2023 21:10

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 12, 2023

lbernick self-assigned this Jun 13, 2023

QuanZhang-William force-pushed the tep-0135-per-pipelinerun-coscheduling branch from 8905234 to 459a38f Compare June 13, 2023 14:13

lbernick reviewed Jun 14, 2023

View reviewed changes

QuanZhang-William force-pushed the tep-0135-per-pipelinerun-coscheduling branch from 459a38f to c168d21 Compare June 15, 2023 20:09

QuanZhang-William force-pushed the tep-0135-per-pipelinerun-coscheduling branch from c168d21 to 49162b2 Compare June 15, 2023 20:23

QuanZhang-William force-pushed the tep-0135-per-pipelinerun-coscheduling branch from 49162b2 to a42969d Compare June 15, 2023 21:59

QuanZhang-William force-pushed the tep-0135-per-pipelinerun-coscheduling branch from a42969d to c1f26ee Compare June 16, 2023 15:04

QuanZhang-William requested a review from lbernick June 16, 2023 15:06

lbernick reviewed Jun 16, 2023

View reviewed changes

pkg/reconciler/pipelinerun/affinity_assistant.go Outdated Show resolved Hide resolved

pkg/reconciler/pipelinerun/affinity_assistant.go Outdated Show resolved Hide resolved

QuanZhang-William force-pushed the tep-0135-per-pipelinerun-coscheduling branch from c1f26ee to afbc67e Compare June 16, 2023 20:18

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2023

QuanZhang-William force-pushed the tep-0135-per-pipelinerun-coscheduling branch from afbc67e to 1bf7ad1 Compare June 16, 2023 20:43

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2023

QuanZhang-William requested a review from Yongxuanzhang June 23, 2023 17:17

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2023

afrittoli added this to the Pipelines v0.50 (LTS) milestone Jun 27, 2023

QuanZhang-William force-pushed the tep-0135-per-pipelinerun-coscheduling branch from daecea3 to 5d29bb6 Compare June 28, 2023 18:12

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2023

Yongxuanzhang reviewed Jun 29, 2023

View reviewed changes

tekton-robot assigned Yongxuanzhang Jun 29, 2023

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2023

tekton-robot merged commit d2cb90d into tektoncd:main Jun 29, 2023

QuanZhang-William mentioned this pull request Jul 13, 2023

[TEP-0135] Coschedule per (Isolated) PipelineRun e2e support #6927

Merged

7 tasks

QuanZhang-William mentioned this pull request Jul 25, 2023

TEP-0135: Coscheduling PipelineRun pods Implementation #6740

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TEP-0135: implement per-pipelinerun coscheduling #6819

TEP-0135: implement per-pipelinerun coscheduling #6819

QuanZhang-William commented Jun 12, 2023 •

edited

Loading

tekton-robot commented Jun 12, 2023

tekton-robot commented Jun 12, 2023

tekton-robot commented Jun 13, 2023

tekton-robot commented Jun 13, 2023

lbernick Jun 14, 2023

QuanZhang-William Jun 16, 2023

tekton-robot commented Jun 15, 2023

tekton-robot commented Jun 15, 2023

tekton-robot commented Jun 15, 2023

tekton-robot commented Jun 15, 2023

tekton-robot commented Jun 15, 2023

tekton-robot commented Jun 15, 2023

tekton-robot commented Jun 16, 2023

tekton-robot commented Jun 16, 2023

tekton-robot commented Jun 22, 2023

tekton-robot commented Jun 22, 2023

QuanZhang-William commented Jun 26, 2023

QuanZhang-William commented Jun 27, 2023

QuanZhang-William commented Jun 28, 2023

tekton-robot commented Jun 28, 2023

tekton-robot commented Jun 28, 2023

QuanZhang-William commented Jun 28, 2023

Yongxuanzhang left a comment

TEP-0135: implement per-pipelinerun coscheduling #6819

TEP-0135: implement per-pipelinerun coscheduling #6819

Conversation

QuanZhang-William commented Jun 12, 2023 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Jun 12, 2023

tekton-robot commented Jun 12, 2023

tekton-robot commented Jun 13, 2023

tekton-robot commented Jun 13, 2023

lbernick Jun 14, 2023

Choose a reason for hiding this comment

QuanZhang-William Jun 16, 2023

Choose a reason for hiding this comment

tekton-robot commented Jun 15, 2023

tekton-robot commented Jun 15, 2023

tekton-robot commented Jun 15, 2023

tekton-robot commented Jun 15, 2023

tekton-robot commented Jun 15, 2023

tekton-robot commented Jun 15, 2023

tekton-robot commented Jun 16, 2023

tekton-robot commented Jun 16, 2023

tekton-robot commented Jun 22, 2023

tekton-robot commented Jun 22, 2023

QuanZhang-William commented Jun 26, 2023

QuanZhang-William commented Jun 27, 2023

QuanZhang-William commented Jun 28, 2023

tekton-robot commented Jun 28, 2023

tekton-robot commented Jun 28, 2023

QuanZhang-William commented Jun 28, 2023

Yongxuanzhang left a comment

Choose a reason for hiding this comment

QuanZhang-William commented Jun 12, 2023 •

edited

Loading