-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge podTemplates instead of overriding #6850
merge podTemplates instead of overriding #6850
Conversation
The podTemplate can be specified for any given pipelineTask at the pipelineRun.spec.taskRunSpecs. The podTemplate can also be specified for the entire pipeline at the pipelineRun.spec.podTemplate. Before this commit, the podTemplates at the pipelineRun level were ignored if it was specified at the taskRunSpecs. This results in the settings specified at the pipelineRun level not included along with the pipelineTask specific configuration. For example, there could be a common setting at the pipelineRun level to set the User and Group for all the pipelineTasks and a pipelineTask can have its own diskType. Without this commit, the taskRun runs with a podTemplate with the specified diskType and no user or group configurations. Signed-off-by: Priti Desai <[email protected]>
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
LGTM! |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
Thanks @dibyom 👍 @tektoncd/core-maintainers please help review this 🙏 I will cherry pick this into previous LTS releases once this is merged, Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop, lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since we have identified and classified this as a bug, backporting this to all active LTS releases (v0.41, v0.44, v0.47). /cherry-pick release-v0.47.x |
@pritidesai: new pull request created: #6860 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-v0.44.x |
/cherry-pick release-v0.41.x |
@pritidesai: #6850 failed to apply on top of branch "release-v0.44.x":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pritidesai: #6850 failed to apply on top of branch "release-v0.41.x":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
The podTemplate can be specified for any given pipelineTask at the pipelineRun.spec.taskRunSpecs.
The podTemplate can also be specified for the entire pipeline at the pipelineRun.spec.podTemplate.
Before this commit, the podTemplates at the pipelineRun level were ignored if it was specified at the taskRunSpecs. This resulted in the settings specified at the pipelineRun level not included along with the pipelineTask specific configuration. For example, there could be a common setting at the pipelineRun level to set the User and Group for all the pipelineTasks and a pipelineTask can have its own diskType. Without this commit, the taskRun runs with a podTemplate with the specified diskType but no user or group configurations.
Fixes #6846
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes