-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEP-0029] Isolated steps and sidecar workspaces to beta #6922
[TEP-0029] Isolated steps and sidecar workspaces to beta #6922
Conversation
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/assign |
2057c67
to
581f32c
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
581f32c
to
11e5a7e
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/hold |
Based on the discussions in TEP-0138, I think now that every feature that we move into beta should not be implicitly on for the |
|
11e5a7e
to
6c0b284
Compare
/hold cancel |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This feature has been implemented in Tekton Pipelines v0.24.0. Isolated workspaces gives our user an option for improved security, which is why it's important to work towards making it available to our users by default. No outstanding issue exists for this feature, except for the proposal to promote it to beta. This feature requires the api-features-flag to be set to beta even when using v1beta1, to avoid running into the issues with v1/v1beta conversion described in TEP-0138. Since this feature has been in alpha until now, this is not a breaking changes, and it's specified in the docs that this feature requires the flag to be set when using v1beta1. Note that this feature was gated both at validation as well as in the reconciler code, which is not how other API driven features are gated. I removed the reconciler code validation to be consistent with the other features. Fixes tektoncd#6109 Signed-off-by: Andrea Frittoli <[email protected]>
6c0b284
to
a90d610
Compare
/lgtm |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
This feature has been implemented in Tekton Pipelines v0.24.0.
Isolated workspaces give our users an option for improved security, which is why it's important to work towards making it available to our users by default.
No outstanding issue exists for this feature, except for the proposal to promote it to beta.
This feature requires the api-features-flag to be set to beta even when using v1beta1, to avoid running into the issues with
v1/v1beta conversion described in TEP-0138. Since this feature has been in alpha until now, this is not a breaking change, and it's specified in the docs that this feature requires the flag to be set when using v1beta1.
Note that this feature was gated both at validation as well as in the reconciler code, which is not how other API driven features are gated. I removed the reconciler code validation to be consistent with the other features.
Fixes #6109
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
/kind feature