Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake of TestPipelineTaskTimeout #6955

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

lbernick
Copy link
Member

Prior to this commit, TestPipelineTaskTimeout was flaky because a Pipeline task that was supposed to succeed timed out. This can happen when the time to create a pod exceeds the timeout, which was 60s.
This commit removes the timeout for that pipeline task, removing this cause of flakes.

/kind flake
closes #6943

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • n/a Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • n/a Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • n/a Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/flake Categorizes issue or PR as related to a flakey test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 20, 2023
@lbernick lbernick marked this pull request as draft July 20, 2023 19:48
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2023
Prior to this commit, TestPipelineTaskTimeout was flaky because
a Pipeline task that was supposed to succeed timed out.
This can happen when the time to create a pod exceeds the timeout,
which was 60s.
This commit removes the timeout for that pipeline task, removing
this cause of flakes.
@lbernick lbernick marked this pull request as ready for review July 21, 2023 11:48
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2023
Copy link
Member

@JeromeJu JeromeJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lbernick

@Yongxuanzhang
Copy link
Member

/lgtm

It would be helpful if we have descriptive names instead of task1 and task2 😂

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JeromeJu, wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2023
@tekton-robot tekton-robot merged commit 83592de into tektoncd:main Jul 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/flake Categorizes issue or PR as related to a flakey test lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flake: TestPipelineTaskTimeout
5 participants