Remove nop container and image

[dicarlo2]

Changes

The nop-image argument describes it as "The container image run at the end of the build to log build success", however currently it just runs immediately on pod start. I'm guessing this is due to the initContainer -> container change.

This PR adds the nop image to the steps so that the entrypointer can apply to the nop container. Critically, this is required for the sidecar workaround described here: #701 (comment).

This PR removes the nop image/container since it is no longer necessary.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

No? I don't think the nop container was really part of the user facing API/contract.

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dicarlo2
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dlorenc

If they are not already assigned, you can assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bobcatfish]

/ok-to-test

[bobcatfish]

Good call @dicarlo2 ! Now that you mention it, we should actually be able to completely get rid of the nop container now that we're not using init containers for the steps!

afaik the reason we had this container was b/c we needed to have at least one container to actually run a pod. now that we're using actual containers, we should be able to completely remove it!

im happy to do this in 2 phases if you want @dicarlo2 , we could merge this first, then in another PR remove the container (and the code for the image even!) but if you want to go straight to removing the container + image entirely that'd be cool too :D

[dicarlo2]

@bobcatfish went ahead and removed the nop container/image entirely. I realized that the workaround I was thinking of doesn't actually require the nop container at all.

[tekton-robot]

@dicarlo2: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-tekton-pipeline-integration-tests	df74d86	link	/test pull-tekton-pipeline-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dicarlo2]

/hold

This image might actually be useful long-term for managing sidecars - working on a small PoC to show how. (The tests failed anyways, but just in case someone retests and they pass)

[dicarlo2]

See #728