-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup to resource types #73
Changes from all commits
213e26f
81b7b71
2145e1e
99d5fb6
d4059d6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,9 +6,8 @@ metadata: | |
spec: | ||
inputs: | ||
resources: | ||
- resourceRef: | ||
name: resource-name | ||
name: workspace | ||
- name: workspace | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i think this should have a type as well, in this case There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. will add type, makes sense for clarity |
||
type: git | ||
params: | ||
- name: pathToHelmCharts | ||
value: string | ||
|
@@ -33,9 +32,8 @@ metadata: | |
spec: | ||
inputs: | ||
resources: | ||
- resourceRef: | ||
name: resource-name | ||
name: workspace | ||
- name: workspace | ||
type: git | ||
params: | ||
- name: kubectlArgs | ||
value: string | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,30 +1,51 @@ | ||
apiVersion: pipeline.knative.dev/v1alpha1 | ||
kind: Resource | ||
metadata: | ||
name: guestbook-resources-sample | ||
name: guestbook-resources-git | ||
namespace: default | ||
spec: | ||
resources: | ||
- name: guestbook | ||
type: git | ||
params: | ||
type: git | ||
params: | ||
- name: url | ||
value: github.com/kubernetes/examples | ||
- name: revision | ||
value: HEAD | ||
- name: serviceAccount | ||
value: githubServiceAccount | ||
--- | ||
apiVersion: pipeline.knative.dev/v1alpha1 | ||
kind: Resource | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. interesting! so one would need to reference each I am fine with doing this but I assumed differently in the examples I wrote out, e.g. in #64 I assumed you could declare one But if it makes more sense to have a separate object for each There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I made this change as part of this PR actually, its because when I started working on the git resource I found that having an array in the Spec that refers to another object makes the code too awkward There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. okay sounds good! |
||
metadata: | ||
name: guestbook-resources-redis-docker | ||
namespace: default | ||
spec: | ||
type: git | ||
params: | ||
- name: url | ||
value: github.com/kubernetes/examples | ||
- name: revision | ||
value: HEAD | ||
value: github.com/GoogleCloudPlatform/redis-docker/ | ||
- name: serviceAccount | ||
value: githubServiceAccount | ||
- name: redis-docker | ||
type: git | ||
params: | ||
- name: url | ||
value: github.com/GoogleCloudPlatform/redis-docker/blob/master/4/debian9/4.0/Dockerfile | ||
- name: serviceAccount | ||
value: githubServiceAccount | ||
- name: revision | ||
value: HEAD | ||
- name: stagingRegistry | ||
type: image | ||
params: | ||
- name: url | ||
value: gcr.io/demo-staging | ||
- name: revision | ||
value: HEAD | ||
--- | ||
apiVersion: pipeline.knative.dev/v1alpha1 | ||
kind: Resource | ||
metadata: | ||
name: guestbookstagingimage | ||
namespace: default | ||
spec: | ||
type: image | ||
params: | ||
- name: url | ||
value: gcr.io/demo-staging | ||
--- | ||
apiVersion: pipeline.knative.dev/v1alpha1 | ||
kind: Resource | ||
metadata: | ||
name: redisstagingimage | ||
namespace: default | ||
spec: | ||
type: image | ||
params: | ||
- name: url | ||
value: gcr.io/redis-demo-staging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, can't believe how easy it is to miss these! Thanks for catching it :D