Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds shortname for taskrun and pipelinerun #743

Merged
merged 1 commit into from
Apr 13, 2019
Merged

Adds shortname for taskrun and pipelinerun #743

merged 1 commit into from
Apr 13, 2019

Conversation

hrishin
Copy link
Member

@hrishin hrishin commented Apr 9, 2019 •
edited
Loading

Changes

During pipeline development, a developer often queries
taskruns and pipelineruns. So a user has to type
these names quite often which is kind of mundane.

This patch adds short names to taskruns and pipelineruns CR's.
So it could improve CLI experience while querying taskruns and
pipelineruns resources.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

Release Notes

Add short names to `taskrun` and `pipelinerun` resources. 
User can use `kubectl <action> tr ...` to deal with `taskruns`
and `kubectl <action> pr ...` to deal with `pipelineruns`.

@hrishin
Add's shortname for taskrun and pipelinerun
d214a53 
During tekton pipeline development, a developer often queries
`taskruns` and `pipelineruns`.

This patch adds shortnames to `taskruns` and `pipelineruns` CR's.
So it could improve CLI experience while querying `taskruns` and
`pipelineruns` resources.
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Apr 9, 2019
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 9, 2019
@hrishin hrishin changed the title Add's shortname for taskrun and pipelinerun Adds shortname for taskrun and pipelinerun Apr 9, 2019
vdemeester
vdemeester reviewed Apr 10, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me
@bobcatfish @imjasonh @abayer wdyt ?

@bobcatfish
Copy link
Collaborator

oh nice, this is awesome! I love it @hrishin !! let's do it

/ok-to-test
/lgtm
/meow space

@tekton-robot
Copy link
Collaborator

@bobcatfish: cat image

In response to this:

oh nice, this is awesome! I love it @hrishin !! let's do it

/ok-to-test
/lgtm
/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2019
@abayer
Copy link
Contributor

abayer commented Apr 13, 2019

Woo! I like.

/approved

vdemeester
vdemeester approved these changes Apr 13, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hrishin, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2019
@tekton-robot tekton-robot merged commit 66847a6 into tektoncd:master Apr 13, 2019
@hrishin
Copy link
Member Author

hrishin commented Apr 15, 2019

Thank you @vdemeester @bobcatfish @abayer 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@vdemeester vdemeester

@bobcatfish bobcatfish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hrishin @bobcatfish @tekton-robot @abayer @vdemeester @googlebot