Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enum validation with multiple param references #7481

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Fix enum validation with multiple param references #7481

merged 1 commit into from
Dec 14, 2023

Commits on Dec 11, 2023

  1. Fix enum validation with multiple param references 

    Fixes [tektoncd#7476][7476]. TEP-0144 requires that the pipeline-level `enum` must be a subset of referenced task-level `enum`.

Prior to this commit, the enum subset validation logic assumes that a task-level param only referenced only one pipeline-level `enum`,
and does not support scenario where multiple pipeline-level `enums` are referenced (e.g., "$(params.p1) and $(params.p2)").

This commit adds the handling logic for such compound references, skipping the subset validation in this scenario as there is no directly associated
params at pipeline level.

/kind bug

[7476]: tektoncd#7476
    @QuanZhang-William
    QuanZhang-William committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    01c7a3f View commit details
    Browse the repository at this point in the history