-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v0.53.x] wait for a given duration in case of imagePullBackOff #7677
[release-v0.53.x] wait for a given duration in case of imagePullBackOff #7677
Conversation
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
We have implemented imagePullBackOff as fail fast. The issue with this approach is, the node where the pod is scheduled often experiences registry rate limit. The image pull failure because of the rate limit returns the same warning (reason: Failed and message: ImagePullBackOff). The pod can potentially recover after waiting for enough time until the cap is expired. Kubernetes can then successfully pull the image and bring the pod up. Introducing a default configuration to specify cluster level timeout to allow the imagePullBackOff to retry for a given duration. Once that duration has passed, return a permanent failure. tektoncd#5987 tektoncd#7184 This is a manual cheery-pick of tektoncd#7666 Signed-off-by: Priti Desai <[email protected]>
e2231cf
to
0773b47
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pritidesai.
As discussed on slack - we usually don't do feature backports, but given that:
- this is a "quality-of-life" change
- the default behaviour does not change
- the change is small enough
- v0.53 is a rather recent LTS
I think it is acceptable.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/meow |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fca993b
into
tektoncd:release-v0.53.x
Changes
We have implemented
imagePullBackOff
to fail fast. The issue with this approach is, this can be a transient error depending on the infrastructure. Often times the node where thepod
is scheduled experiences registry rate limit. The image pull failure because of the rate limit returns the same warning (reason:Failed
and message:ImagePullBackOff
) compared to other authentication failure, missing image, etc. In case of a rate limit, the pod can potentially recover after waiting for enough time until the cap is expired. Kubernetes can then successfully pull the image and bring the pod up. But the fail fast approach results in ataskRun
failure and hencepipelineRun
results in a failure.Introducing a default configuration to specify cluster level timeout to allow the
imagePullBackOff
to retry for a given duration. Once that duration has passed, controller returns a permanent failure.#5987
#7184
This is a manual cheery-pick of #7666
/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes