Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure default type for params in remote tasks to prevent pipeline failures #7776

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix: ensure default type for params in remote tasks to prevent pipeline failures #7776

merged 1 commit into from
Apr 25, 2024
+75 −15

Commits on Apr 24, 2024

  1. fix: ensure default type for params in remote tasks to prevent pipeli… 

    …ne failures

fix tektoncd#7775

In the existing logic, resources used for ConvertTo should have default values set.
Otherwise, there could be issues with incorrect parameter types being set
(e.g., an array type being treated as a string type).

However, resources fetched from remote sources haven't undergone the SetDefaults
operation. If we directly invoke the ConvertTo operation, it might result in
erroneous outcomes.

For instance, a v1beta1 ClusterTask that undergoes a direct ConvertTo to convert
the resource into a v1 Task for validation might be mistakenly considered invalid.

Additionally, even if a v1beta1 Task passes validation, the process of converting
it to a v1 Task could still incorrectly set default parameter types, leading to
errors during execution.
    @l-qing
    l-qing committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    d8e6d8b View commit details
    Browse the repository at this point in the history