Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump knative/pkg to 1.13 and k8s.io to 0.28.5 #7808

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

vdemeester
Copy link
Member

Changes

This updates core dependencies of knative/pkg to it's latest release,
1.13. And it updates the k8s.io dependencies according to it.

Note: this moves the min kubernetes version to 1.27 for tektoncd/pipeline.

Signed-off-by: Vincent Demeester [email protected]

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

knative/pkg dependency is now 1.13 and k8s.io dependencies are 0.28.x.
In addition, this make the minimum kubernetes version supported by tektoncd/pipeline to be 1.27.

@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 27, 2024
@vdemeester
Copy link
Member Author

/cc @tektoncd/core-maintainers

@tekton-robot tekton-robot requested a review from a team March 27, 2024 00:32
@vdemeester
Copy link
Member Author

/retest

This updates core dependencies of knative/pkg to it's latest release,
1.13. And it updates the k8s.io dependencies according to it.

Note: this moves the min kubernetes version to 1.27 for tektoncd/pipeline.

Signed-off-by: Vincent Demeester <[email protected]>
@khrm
Copy link
Contributor

khrm commented Mar 27, 2024

/test pull-tekton-pipeline-integration-tests

@vdemeester
Copy link
Member Author

I need to update the kind version we use here.

vdemeester added a commit to vdemeester/tektoncd-plumbing that referenced this pull request Mar 28, 2024
`tektoncd/pipeline` will soon require 1.27 as minimum kubernetes
version (see tektoncd/pipeline#7808), so updating the CI a bit ahead
of time for everyone.

Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester
Copy link
Member Author

tektoncd/plumbing#1907 for bumping kind version

tekton-robot pushed a commit to tektoncd/plumbing that referenced this pull request Mar 28, 2024
`tektoncd/pipeline` will soon require 1.27 as minimum kubernetes
version (see tektoncd/pipeline#7808), so updating the CI a bit ahead
of time for everyone.

Signed-off-by: Vincent Demeester <[email protected]>
@JeromeJu
Copy link
Member

tektoncd/plumbing#1907 for bumping kind version

/retest
now that plumbing 1907 is merged

@vdemeester
Copy link
Member Author

 [clone-coverage-upload : clone] {"level":"error","ts":1711581650.6748326,"caller":"git/git.go:54","msg":"Error running git [fetch --recurse-submodules=yes origin --update-head-ok --force refs/heads/main:refs/heads/main refs/pull/7808/head:refs/batch/refs/pull/7808/head]: exit status 128\nremote: Repository not found.\nfatal: repository 'https://github.com/$(tasks.split-full-repo-name.results.repoOwner)/$(tasks.split-full-repo-name.results.repoName).git/' not found\n","stacktrace":"github.com/tektoncd/pipeline/pkg/git.run\n\tgithub.com/tektoncd/pipeline/pkg/git/git.go:54\ngithub.com/tektoncd/pipeline/pkg/git.Fetch\n\tgithub.com/tektoncd/pipeline/pkg/git/git.go:145\nmain.main\n\tgithub.com/tektoncd/pipeline/cmd/git-init/main.go:52\nruntime.main\n\truntime/proc.go:204"}
[clone-coverage-upload : clone] {"level":"fatal","ts":1711581650.6749718,"caller":"git-init/main.go:53","msg":"Error fetching git repository: failed to fetch [refs/heads/main:refs/heads/main refs/pull/7808/head:refs/batch/refs/pull/7808/head]: exit status 128","stacktrace":"main.main\n\tgithub.com/tektoncd/pipeline/cmd/git-init/main.go:53\nruntime.main\n\truntime/proc.go:204"} 

🤔 I don't understand why pull-tekton-pipeline-go-coverage-df fails with this sometimes…

@vdemeester
Copy link
Member Author

/test pull-tekton-pipeline-go-coverage-df

@tekton-robot
Copy link
Collaborator

@vdemeester: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chitrangpatel
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2024
@chitrangpatel
Copy link
Contributor

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2024
@tekton-robot tekton-robot merged commit 8450e1b into tektoncd:main Apr 2, 2024
13 checks passed
@vdemeester vdemeester deleted the bump-knative-1.13 branch April 2, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants