validate TaskRun retries in TestRunSpec is greater than or equal to zero

[Ma-YuXin]

Changes

fixes: #7778

• this pr verifies the Retries in TaskRunSpec to ensure that its value is not less than zero.
  At the same time, two test cases are added to verify when the value is greater than zero and less than zero.

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• pre-commit Passed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

fix: the retries value has not been verified

[tekton-robot]

@Ma-YuXin: The label(s) kind/fix cannot be applied, because the repository doesn't have them.

In response to this:

Changes

fixes: #7778

• this pr verifies the Retries in TaskRunSpec to ensure that its value is not less than zero.
  At the same time, two test cases are added to verify when the value is greater than zero and less than zero.

/kind fix

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• pre-commit Passed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

fix: the retries value has not been verified

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Ma-YuXin / name: YuXinMa (d96567e)

[tekton-robot]

Hi @Ma-YuXin. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/taskrun_validation.go	96.9%	96.9%	0.0

[Ma-YuXin]

/kind bug

[Ma-YuXin]

/assign @jerop

[khrm]

/ok-to-test

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/taskrun_validation.go	96.9%	96.9%	0.0

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/pod/template.go	75.3%	80.7%	5.4
pkg/apis/pipeline/v1/taskrun_validation.go	96.9%	96.9%	0.0

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/taskrun_validation.go	96.9%	96.9%	0.0

[Ma-YuXin]

@vdemeester @khrm Sorry, I made a mistake because it was the first time I participated in the open source contribution, so I was not very familiar with the process. After I submitted pr yesterday, I wanted to solve another issue today. When I submitted the code, I found that the pr submitted yesterday was affected. I don't know how to revoke the commit submitted today in pr. It should belong to a new pr.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/taskrun_validation.go	96.9%	96.9%	0.0

[afrittoli]

@vdemeester @khrm Sorry, I made a mistake because it was the first time I participated in the open source contribution, so I was not very familiar with the process. After I submitted pr yesterday, I wanted to solve another issue today. When I submitted the code, I found that the pr submitted yesterday was affected. I don't know how to revoke the commit submitted today in pr. It should belong to a new pr.

It looks like the PR is fine now, thanks for the fix

[afrittoli]

/lgtm