Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update issue templates #8

Merged
merged 1 commit into from
Sep 7, 2018
Merged

Update issue templates #8

merged 1 commit into from
Sep 7, 2018

Conversation

bobcatfish
Copy link
Collaborator

Add an issue template - this is pretty much a copy of the knative/serving template at https://github.com/knative/serving/blob/master/.github/issue-template.md

@bobcatfish
Update issue templates
7c6bb68 
Add an issue template - this is pretty much a copy of the knative/serving template at https://github.com/knative/serving/blob/master/.github/issue-template.md
@tejal29 tejal29 mentioned this pull request Sep 7, 2018
Closed
@bobcatfish
Copy link
Collaborator Author

Maybe later on we might want to add some /area /kind notations like knative/serving uses, but at the moment those wouldn't do anything b/c we'd need a system like Prow to consume those and add labels from them.

@bobcatfish bobcatfish merged commit b265f35 into master Sep 7, 2018
@bobcatfish bobcatfish deleted the issue-template branch September 7, 2018 20:14
vdemeester referenced this pull request in vdemeester/tektoncd-pipeline Apr 3, 2019
@vdemeester
Merge pull request #8 from arilivigni/updates-to-ocp4
321de5b 
Update to use OCP 4
chmouel pushed a commit to chmouel/tektoncd-pipeline that referenced this pull request Apr 11, 2019
@vdemeester
Merge pull request tektoncd#8 from arilivigni/updates-to-ocp4
2e4c0a1 
Update to use OCP 4
popcor255 added a commit to popcor255/pipeline that referenced this pull request Mar 30, 2020
@popcor255
# This is a combination of 8 commits.
490e446 
# This is the 1st commit message:

change tutorial to getting-started

# This is the commit message tektoncd#2:

update some of the docs

# This is the commit message tektoncd#3:

Remove/Modify local registry setup

This is a getting-started guide and if the user was able to get to this doc. It means they have access to the internet. It is probably easier for the user to create docker hub account then to setup a local image registry. It is probably more secure/convenient to push an image to docker hub with an api token that can revoked then depending on a local registry

# This is the commit message tektoncd#4:

change from we to you

chaning we to you because it is the user doing the tutorial

# This is the commit message tektoncd#5:

change from we to you

# This is the commit message tektoncd#6:

parent 6328deb
author popcor255 <[email protected]> 1585337853 -0500
committer popcor255 <[email protected]> 1585608100 -0400

Restoring tutorial.md

There are alot of docs referencing to this doc. This doc will need to be removed eventually. However, I will keep in here for now

Restoring bullet point that outlines the tutorial

changing 'docker' to Docker

remove 'also' from sentences

change tekton piplines to Tekton Pipelines

changed the logs and regred to have docker.io

changed some of the output logs from the results of the instructions because they did not reflect the changes that were made

correct grammar

The namespace does not matter the tutorial will work either way

Change pipeline

Change pipeline and task with inline-yaml

Remove/Modify local registry setup

This is a getting-started guide and if the user was able to get to this doc. It means they have access to the internet. It is probably user for them to create docker account then to setup a local image registry. It is probably more secure to push an image to docker hub with an api token that can revoked then depending on a local registry

change from we to you

chaning we to you because it is the user doing the tutorial

change from we to you

Restoring tutorial.md

There are alot of docs referencing to this doc. This doc will need to be removed eventually. However, I will keep in here for now

Restoring bullet point that outlines the tutorial

correct grammar

The namespace does not matter the tutorial will work either way

Change pipeline

Change pipeline and task with inline-yaml

# This is the commit message tektoncd#7:

Restoring tutorial.md

There are alot of docs referencing to this doc. This doc will need to be removed eventually. However, I will keep in here for now

# This is the commit message tektoncd#8:

Restoring bullet point that outlines the tutorial
lumjjb pushed a commit to lumjjb/pipeline that referenced this pull request Mar 3, 2022
@pxp928
uri check, annotation added and code cleanup (tektoncd#8)
8f0d83e 
* add annotations for verified condition

Signed-off-by: pxp928 <[email protected]>

* cleaned code and added uri check

Signed-off-by: pxp928 <[email protected]>

* added annotataions for status

Signed-off-by: pxp928 <[email protected]>

* updated status validation and hash check

Signed-off-by: pxp928 <[email protected]>

* fixed issues and code cleanup based on comments

Signed-off-by: pxp928 <[email protected]>
Yongxuanzhang referenced this pull request in Yongxuanzhang/pipeline May 2, 2022
@Yongxuanzhang
# This is a combination of 8 commits.
e7a36b3 
# This is the 1st commit message:

change emitting results

# This is the commit message #2:

fix code

# This is the commit message #3:

A few minor cleanups in pkg/reconciler/pipelinerun/pipelinerun_test.go

These just mildly annoyed me, so I thought I'd clean them up.

Signed-off-by: Andrew Bayer <[email protected]>

# This is the commit message #4:

Instrument e2e pipelinerun_test.go files for logstream

These two (`test/pipelinerun_test.go` and `test/v1alpha1/pipelinerun_test.go`)
weren't done in the last PR, because they were messy and I wanted to get that PR
in. But I had some time this morning, so here they are, which should be the last
things in the e2e tests (other than examples/yamls testing, which are their own
bucket of worms) to be instrumented with `helpers.ObjectNameForTest(t)`.

Signed-off-by: Andrew Bayer <[email protected]>

# This is the commit message #5:

Update tutorial links

We recently updated the introductory tutorial on the documnentation
website. That tutorial covers the same content as the one here. To avoid
duplicated efforts and content drift, I'm linkin that doc here and
replacing the existing content.

Additionally, this removes references to `PipelineResources`.

# This is the commit message #6:

Set git-clone tasks in examples to run as root

Similar to tektoncd@ba2e7f3 -
with tektoncd#4758, `git-init` now uses `ghcr.io/distroless/git` as
its base image, and that image needs to run as root. `git-init` by default does _not_ run as root.
So the two examples using copy-pasted old versions of the `git-clone` catalog task need to be
changed to run as root, or the example tests will keep failing forever.

An equivalent change will be needed in the `git-clone` catalog task once it's bumped to using
`git-init:v0.35.0` or later - currently, it's using `v0.29.0`.

Signed-off-by: Andrew Bayer <[email protected]>

# This is the commit message #7:

adding latest release - 0.35

Updating the table to include the latest release links.

# This is the commit message #8:

Added a unit test for pod status.

Add unit test with large result for setTaskRunStatusBasedOnStepStatus.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobcatfish @tejal29