-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update issue templates #8
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an issue template - this is pretty much a copy of the knative/serving template at https://github.com/knative/serving/blob/master/.github/issue-template.md
tejal29
approved these changes
Sep 7, 2018
Maybe later on we might want to add some |
vdemeester
referenced
this pull request
in vdemeester/tektoncd-pipeline
Apr 3, 2019
Update to use OCP 4
chmouel
pushed a commit
to chmouel/tektoncd-pipeline
that referenced
this pull request
Apr 11, 2019
Update to use OCP 4
popcor255
added a commit
to popcor255/pipeline
that referenced
this pull request
Mar 30, 2020
# This is the 1st commit message: change tutorial to getting-started # This is the commit message tektoncd#2: update some of the docs # This is the commit message tektoncd#3: Remove/Modify local registry setup This is a getting-started guide and if the user was able to get to this doc. It means they have access to the internet. It is probably easier for the user to create docker hub account then to setup a local image registry. It is probably more secure/convenient to push an image to docker hub with an api token that can revoked then depending on a local registry # This is the commit message tektoncd#4: change from we to you chaning we to you because it is the user doing the tutorial # This is the commit message tektoncd#5: change from we to you # This is the commit message tektoncd#6: parent 6328deb author popcor255 <[email protected]> 1585337853 -0500 committer popcor255 <[email protected]> 1585608100 -0400 Restoring tutorial.md There are alot of docs referencing to this doc. This doc will need to be removed eventually. However, I will keep in here for now Restoring bullet point that outlines the tutorial changing 'docker' to Docker remove 'also' from sentences change tekton piplines to Tekton Pipelines changed the logs and regred to have docker.io changed some of the output logs from the results of the instructions because they did not reflect the changes that were made correct grammar The namespace does not matter the tutorial will work either way Change pipeline Change pipeline and task with inline-yaml Remove/Modify local registry setup This is a getting-started guide and if the user was able to get to this doc. It means they have access to the internet. It is probably user for them to create docker account then to setup a local image registry. It is probably more secure to push an image to docker hub with an api token that can revoked then depending on a local registry change from we to you chaning we to you because it is the user doing the tutorial change from we to you Restoring tutorial.md There are alot of docs referencing to this doc. This doc will need to be removed eventually. However, I will keep in here for now Restoring bullet point that outlines the tutorial correct grammar The namespace does not matter the tutorial will work either way Change pipeline Change pipeline and task with inline-yaml # This is the commit message tektoncd#7: Restoring tutorial.md There are alot of docs referencing to this doc. This doc will need to be removed eventually. However, I will keep in here for now # This is the commit message tektoncd#8: Restoring bullet point that outlines the tutorial
lumjjb
pushed a commit
to lumjjb/pipeline
that referenced
this pull request
Mar 3, 2022
* add annotations for verified condition Signed-off-by: pxp928 <[email protected]> * cleaned code and added uri check Signed-off-by: pxp928 <[email protected]> * added annotataions for status Signed-off-by: pxp928 <[email protected]> * updated status validation and hash check Signed-off-by: pxp928 <[email protected]> * fixed issues and code cleanup based on comments Signed-off-by: pxp928 <[email protected]>
Yongxuanzhang
referenced
this pull request
in Yongxuanzhang/pipeline
May 2, 2022
# This is the 1st commit message: change emitting results # This is the commit message #2: fix code # This is the commit message #3: A few minor cleanups in pkg/reconciler/pipelinerun/pipelinerun_test.go These just mildly annoyed me, so I thought I'd clean them up. Signed-off-by: Andrew Bayer <[email protected]> # This is the commit message #4: Instrument e2e pipelinerun_test.go files for logstream These two (`test/pipelinerun_test.go` and `test/v1alpha1/pipelinerun_test.go`) weren't done in the last PR, because they were messy and I wanted to get that PR in. But I had some time this morning, so here they are, which should be the last things in the e2e tests (other than examples/yamls testing, which are their own bucket of worms) to be instrumented with `helpers.ObjectNameForTest(t)`. Signed-off-by: Andrew Bayer <[email protected]> # This is the commit message #5: Update tutorial links We recently updated the introductory tutorial on the documnentation website. That tutorial covers the same content as the one here. To avoid duplicated efforts and content drift, I'm linkin that doc here and replacing the existing content. Additionally, this removes references to `PipelineResources`. # This is the commit message #6: Set git-clone tasks in examples to run as root Similar to tektoncd@ba2e7f3 - with tektoncd#4758, `git-init` now uses `ghcr.io/distroless/git` as its base image, and that image needs to run as root. `git-init` by default does _not_ run as root. So the two examples using copy-pasted old versions of the `git-clone` catalog task need to be changed to run as root, or the example tests will keep failing forever. An equivalent change will be needed in the `git-clone` catalog task once it's bumped to using `git-init:v0.35.0` or later - currently, it's using `v0.29.0`. Signed-off-by: Andrew Bayer <[email protected]> # This is the commit message #7: adding latest release - 0.35 Updating the table to include the latest release links. # This is the commit message #8: Added a unit test for pod status. Add unit test with large result for setTaskRunStatusBasedOnStepStatus.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an issue template - this is pretty much a copy of the knative/serving template at https://github.com/knative/serving/blob/master/.github/issue-template.md