[WIP] Upload code coverage reports to codecov.io #835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The token is currently hardcoded which is probably terrible but only viable alternatives I can think of are to hardcode it in tektoncd/plumbing, which doesn't seem much better, or to put it into a secret in the Prow cluster, which we could do later if this becomes a problem I am not 100% sure if this will work with the existing knative bash scripts, really looking forward to tektoncd#532 These commands worked when run locally, except the generated deepcopy file was included in the coverage reporting. No matter what I did to try to exclude it (https://docs.codecov.io/docs/ignoring-paths) I couldn't make it work, so putting that aside for now (and continuing to try to chip away at it in tektoncd#834)
googlebot
added
the
cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
approved
|
Hmm results in a |
bobcatfish
changed the title
tekton-robot
added
the
do-not-merge/work-in-progress
|
I'm guessing that the problem is that the prow setup is merging master in before running this: |
|
I'm gonna close this for now, I think I might think seriously about taking on #532 before doing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The token is currently hardcoded which is probably terrible but
only viable alternatives I can think of are
to hardcode it in tektoncd/plumbing, which doesn't seem much better, or to put it into
a secret in the Prow cluster, which we could do later if this becomes a problem
I am not 100% sure if this will work with the existing knative bash
scripts, really looking forward to #532
These commands worked when run locally, except the generated deepcopy
file was included in the coverage reporting. No matter what I did to try
to exclude it (https://docs.codecov.io/docs/ignoring-paths) I couldn't
make it work, so putting that aside for now (and continuing to try to
chip away at it in #834)
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.