Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump prow test-runner. #1369

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Bump prow test-runner. #1369

merged 1 commit into from
Feb 22, 2023

Conversation

wlynch
Copy link
Member

@wlynch wlynch commented Feb 22, 2023

Changes

Primarily to upgrade to Go 1.19.

$ docker run --entrypoint bash -it gcr.io/tekton-releases/dogfooding/test-runner@sha256:9b8548ad06ebb2acc420aa588d47637bd37e9f563588f47c43b22560dc1ce3f8   
root@1c25d7f1b443:/# go version
go version go1.19 linux/amd64

NOTE: This may cause some test failures due to changes in gofmt. Repos just need to re-run codegen w/ Go 1.19+ once this is live.

Fixes tektoncd/pipeline#5771

/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

Primarily to upgrade to Go 1.19.

NOTE: This may cause some test failures due to changes in gofmt. Repos
just need to re-run codegen w/ Go 1.19+ once this is live.
@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Feb 22, 2023
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 22, 2023
@wlynch
Copy link
Member Author

wlynch commented Feb 22, 2023

/cc @vdemeester

Copy link
Member

@JeromeJu JeromeJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Billy:)

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JeromeJu, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2023
@tekton-robot tekton-robot merged commit 50366b3 into tektoncd:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indent missmatches after running .hack/update-codegen.sh
4 participants