Add nightly Pipeline + try to fix some upgrade test stuff #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the configuration to run the Pipeline + Tasks being added in tektoncd/pipeline#1274 every night at midnight PDT. I've successfully run this by setting the cron to every 5 minutes. This configuration is already applied to the repo. Status can be seen at https://prow.tekton.dev/?type=periodic. Part of tektoncd/pipeline#860
It looked like the indentation was off, and also some of the environment variables (e.g. $PULL_REF) provided to presubmit jobs aren't provided to presubmit jobs. I tried to copy example configuration in the kubernetes test-infra repo but the prow "initupload" container is still failing with an error about cloning refs. (continuation of tektoncd#56)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
approved
vdemeester
reviewed
Sep 5, 2019
|
lol I forgot it was already approved, Oops =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Unfortunately this PR is a mix of 2 different changes b/c the changes all had to go into the same file and I had to fix them at the same time to apply them. They are in 2 separate commits tho!
Change 1: Nightly release pipeline
Add nightly Pipelines release crescent_moon
This is the configuration to run the Pipeline + Tasks being added in
tektoncd/pipeline#1274 every night at midnight
PDT.
I've successfully run this by setting the cron to every 5 minutes. This
configuration is already applied to the repo.
Status can be seen at https://prow.tekton.dev/?type=periodic.
Part of tektoncd/pipeline#860
Change 2: Trying to get upgrade test running (WIP)
Trying to get upgrade test working construction
It looked like the indentation was off, and also some of the environment
variables (e.g. $PULL_REF) provided to presubmit jobs aren't provided
to presubmit jobs. I tried to copy example configuration in the
kubernetes test-infra repo but the prow "initupload" container is still
failing with an error about cloning refs.
(continuation of #56)
Needs some more work tho @houshengbo @vdemeester
I think the only significant change in the PR is
github.com/$(REPO_OWNER)/$(REPO_NAME)=$(PULL_REFS)"being hardcoded now. I also changed some indentation to be consistent but I'm not sure that mattered.It still isn't working (https://prow.tekton.dev/?type=periodic).
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.