This repository has been archived by the owner on Apr 18, 2023. It is now read-only.
TEP-0115: Add git revision resolution support in Git Resolver #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
tekton-robot
added
the
do-not-merge/work-in-progress
tekton-robot
added
the
size/L
|
/test all |
|
Looks good! |
QuanZhang-William
force-pushed
the
tep-0110-add-git-revision-resolution-support
branch
from
581adcd
to
455d3c7
Compare
tekton-robot
removed
the
do-not-merge/work-in-progress
|
/assign @jerop |
QuanZhang-William
added a commit
to QuanZhang-William/pipeline
that referenced
this pull request
Jul 29, 2022
Part of TEP-0110 Update Git Resolver example to use ```revision``` and ```pathInRepo``` fields to reflect the changes in [TEP-0110: Add git revision resolution suppot in Git Resolver](tektoncd/resolution#75) and [Add core Reconciler testing and fake resolver framework functions](tektoncd/resolution#51)
Merged
7 tasks
QuanZhang-William
added a commit
to QuanZhang-William/pipeline
that referenced
this pull request
Jul 29, 2022
Part of TEP-0115 Update Git Resolver example to use ```revision``` and ```pathInRepo``` fields to reflect the changes in [TEP-0110: Add git revision resolution suppot in Git Resolver](tektoncd/resolution#75) and [Add core Reconciler testing and fake resolver framework functions](tektoncd/resolution#51)
QuanZhang-William
added a commit
to QuanZhang-William/pipeline
that referenced
this pull request
Jul 29, 2022
Part of TEP-0115 Update Git Resolver example to use ```revision``` and ```pathInRepo``` fields to reflect the changes in [TEP-0115: Add git revision resolution suppot in Git Resolver](tektoncd/resolution#75) and [Add core Reconciler testing and fake resolver framework functions](tektoncd/resolution#51)
QuanZhang-William
changed the title
Prior to this change, users need to specify git commit or branch fields when using git resolver. This commits replaces the "commit" and "branch" with "revision" fields, which support git commit, branch and tag. This change extends the usability of git resolver and also provides a better user experience.
QuanZhang-William
force-pushed
the
tep-0110-add-git-revision-resolution-support
branch
from
455d3c7
to
b1395cd
Compare
|
/approve I'll give it a couple days to see if anyone else has thoughts on this, and then I'll lgtm it, and incorporate this change into my work-in-progress on moving Resolution into Pipeline. |
tekton-robot
added
the
approved
jerop
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
TEP-0115 has not yet been merged but this change is useful in remote resolution either way
Thank you @QuanZhang-William!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer, jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm switching my approval to lgtm |
QuanZhang-William
added a commit
to QuanZhang-William/pipeline
that referenced
this pull request
Aug 8, 2022
Part of TEP-0115 Update Git Resolver example to use ```revision``` and ```pathInRepo``` fields to reflect the changes in [TEP-0115: Add git revision resolution suppot in Git Resolver](tektoncd/resolution#75) and [Add core Reconciler testing and fake resolver framework functions](tektoncd/resolution#51)
QuanZhang-William
changed the title
QuanZhang-William
added a commit
to QuanZhang-William/resolution
that referenced
this pull request
Aug 8, 2022
Part of TEP-0115 Update Git Resolver documentation to use "revision" and "pathInRepo" fields to reflect the changes in [TEP-0115: Add git revision resolution support in Git Resolver](tektoncd#75) and [Add core Reconciler testing and fake resolver framework functions](tektoncd#51)
QuanZhang-William
added a commit
to QuanZhang-William/resolution
that referenced
this pull request
Aug 8, 2022
Part of TEP-0115 Update Git Resolver documentation to use "revision" and "pathInRepo" fields to reflect the changes in [TEP-0115: Add git revision resolution support in Git Resolver](tektoncd#75) and [Add core Reconciler testing and fake resolver framework functions](tektoncd#51)
QuanZhang-William
added a commit
to QuanZhang-William/resolution
that referenced
this pull request
Aug 8, 2022
Part of TEP-0115 Update Git Resolver documentation to use "revision" and "pathInRepo" fields to reflect the changes in [TEP-0115: Add git revision resolution support in Git Resolver](tektoncd#75) and [Add core Reconciler testing and fake resolver framework functions](tektoncd#51)
QuanZhang-William
added a commit
to QuanZhang-William/pipeline
that referenced
this pull request
Aug 8, 2022
Part of TEP-0115 Update git resolver example to use "revision" and "pathInRepo" fields to reflect the changes in [TEP-0115: Add git revision resolution suppot in Git Resolver](tektoncd/resolution#75) and [Add core Reconciler testing and fake resolver framework functions](tektoncd/resolution#51)
tekton-robot
pushed a commit
to tektoncd/pipeline
that referenced
this pull request
Aug 9, 2022
Part of TEP-0115 Update git resolver example to use "revision" and "pathInRepo" fields to reflect the changes in [TEP-0115: Add git revision resolution suppot in Git Resolver](tektoncd/resolution#75) and [Add core Reconciler testing and fake resolver framework functions](tektoncd/resolution#51)
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add git revision resolution support in Git Resolver
Prior to this change, users need to specify git commit or branch fields when using git resolver. This commits replaces the
commitandbranchwithrevisionfields, which support gitcommit,branchandtag. This change extends the usability of git resolver and also provides a better user experience.