Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a skeleton controller #18

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Create a skeleton controller #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions .errcheck.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
(*github.com/tektoncd/pipeline/vendor/go.uber.org/zap.SugaredLogger).Sync
9 changes: 9 additions & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
run:
build-tags:
- e2e
skip-dirs:
- vendor
- pkg/client/clientset/versioned/fake
linters-settings:
errcheck:
exclude: .errcheck.txt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooo what's this file for? ive never seen this before! :D

(question about both the .golangci.yaml and the .errcheck.txt!)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the config file for our linter golangci-lint (more info here). .errcheck.txt lists files to exclude from testing. However, I don't think we need .errcheck.txt anymore, because the linter error we were skipping was fixed the correct way in @vincent-pli's webhook PR 😅

I'm going to remove the .errcheck.txt file in a PR that I'm putting together, because I don't think we need it anymore.

Loading