Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would it be possible to use an older glibc? #112

Closed
darkvertex opened this issue Sep 17, 2024 · 9 comments · Fixed by #121
Closed

Would it be possible to use an older glibc? #112

darkvertex opened this issue Sep 17, 2024 · 9 comments · Fixed by #121

Comments

@darkvertex
Copy link

darkvertex commented Sep 17, 2024 •
edited
Loading

I can't use typos-lsp remotely (via VSCode's Remote Host extension) on my employer Linux machines because they're on RockyLinux 8 which uses glibc-2.28.236 but typos-lsp from you needs glibc 2.29:

> ldd ./typos-lsp
./typos-lsp: /lib64/libm.so.6: version `GLIBC_2.29' not found (required by ./typos-lsp)
        linux-vdso.so.1 (0x00007fffccbf1000)
        libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00007f81108d2000)
        libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f81106b2000)
        libm.so.6 => /lib64/libm.so.6 (0x00007f8110330000)
        libdl.so.2 => /lib64/libdl.so.2 (0x00007f811012c000)
        libc.so.6 => /lib64/libc.so.6 (0x00007f810fd67000)
        /lib64/ld-linux-x86-64.so.2 (0x00007f8111bce000)

Any chance you could make the Linux executable more broadly compatible? Statically compile it maybe? Or require an older glibc?
@tekumara
Copy link
Owner

Happy to add a tier 2 musl build to support this - are you using aarch64 or x86_64?

@darkvertex
Copy link
Author

x86_64

@darkvertex
Copy link
Author

Hey, are we sure v0.1.24 released okay? It only has source code in the "Assets" of the release:
https://github.com/tekumara/typos-lsp/releases/tag/v0.1.24
vs say the release before that, which has many executables ready for download:
https://github.com/tekumara/typos-lsp/releases/tag/v0.1.23

@tekumara tekumara mentioned this issue Sep 23, 2024
Merged
@tekumara
Copy link
Owner

Oops - I'll have to investigate why I didn't get notified for that. Cutting a new 0.1.25 release now.

@darkvertex
Copy link
Author

Thanks for the quick fix! I confirm the new "unknown-linux-musl" build runs where the old one wouldn't. Cool. :)

That said, the one bundled is still the one requiring glibc 2.29. I added the statically compiled typos-lsp executable in my PATH to no avail.

How can I point the extension to the good executable? I looked for a custom preference to override the path but there doesn't appear to be one.

@tekumara
Copy link
Owner

Try the setting typos.path.

It may make sense to bundle the musl binary with the VS Code extension if the memory hit isn't too bad.

@darkvertex
Copy link
Author

Setting typos.path worked, thank you :)

tekumara added a commit that referenced this issue Oct 3, 2024
@tekumara
feat(vscode): publish the x86_64 musl target
1bde263 
resolves #112
@potatobot-prime potatobot-prime bot mentioned this issue Oct 2, 2024
Merged
tekumara pushed a commit that referenced this issue Oct 3, 2024
@potatobot-prime
chore(main): release 0.1.27 (#121)
0269511 
🤖 I have created a release *beep* *boop*
---


##
[0.1.27](v0.1.26...v0.1.27)
(2024-10-03)


### Features

* typos 1.25.0 September 2024 dictionary
([#120](#120))
([cfc1c3f](cfc1c3f))
* **vscode:** publish the x86_64 musl target
([1bde263](1bde263)),
closes [#112](#112)


### Chores

* **deps-dev:** bump the vscode group with 10 updates
([#118](#118))
([3b09555](3b09555))
* **deps:** bump the lsp group with 3 updates
([#119](#119))
([949fe96](949fe96))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: potatobot-prime[bot] <132267321+potatobot-prime[bot]@users.noreply.github.com>
@tekumara
Copy link
Owner

tekumara commented Oct 3, 2024

The latest release now bundles the musl binary so you can unset typos.path and just use the bundled version.

@darkvertex
Copy link
Author

Wonderful! Thanks dude.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(main): release 0.1.27 tekumara/typos-lsp
2 participants
@tekumara @darkvertex