Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tab-nav): fixes preselect logic in tabs with disabled attribute #2320

Merged

Conversation

tshimber
Copy link
Contributor

@tshimber tshimber commented Jun 11, 2024

Fixes #2282

  • now if selected tab gots disabled, selection moves to first available tab
  • example of preselected tab logic added to storybook

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit b88c2fe
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/671f9d8f1b50650008eb7574
😎 Deploy Preview https://deploy-preview-2320--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@maomaoZH maomaoZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tshimber thanks for the PR. LGTM.

@tshimber
Copy link
Contributor Author

@tshimber thanks for the PR. LGTM.

@maomaoZH thank you! but unfortunately it doesn't work in deployed version🫠 I try to understand now, how these storybook templates are working. sorry, i'll put the draft mark now..

@tshimber tshimber changed the title preselected tab in tab-nav added to storybook Draft: preselected tab in tab-nav added to storybook Jun 11, 2024
@maomaoZH
Copy link
Collaborator

@tshimber Scale is still using storybook 7. So it is a bit tricky to add story.

@tshimber
Copy link
Contributor Author

@tshimber Scale is still using storybook 7. So it is a bit tricky to add story.

I need to add fixes to current) I've understood how templates in storybook are working, so now it seems fine. Could you take a look again?
Maybe you have some comments to naming or smth else?

Here's how it looks now:
image

@tshimber tshimber changed the title Draft: preselected tab in tab-nav added to storybook preselected tab in tab-nav added to storybook Jun 11, 2024
@tshimber tshimber changed the title preselected tab in tab-nav added to storybook Draft: preselected tab in tab-nav Aug 8, 2024
@tshimber tshimber changed the title Draft: preselected tab in tab-nav preselected tab in tab-nav Aug 12, 2024
@amir-ba amir-ba added the feature New component features and enhancements label Aug 20, 2024
@tshimber tshimber force-pushed the feature-preselected-tab-in-tab-navigation branch from 527cb89 to 8786cf6 Compare August 28, 2024 10:31
@amir-ba amir-ba changed the title preselected tab in tab-nav fix(tab-nav): fixes preselect logic in tabs with disabled attribute Oct 24, 2024
@amir-ba amir-ba added bug Something isn't working docs Mostly related to documentation and removed feature New component features and enhancements labels Oct 24, 2024
@amir-ba amir-ba merged commit bd30a6f into telekom:main Oct 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Mostly related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tab Navigation] Programmatically select tabs
3 participants