Skip to content
This repository has been archived by the owner on Apr 11, 2018. It is now read-only.

docs: add CSS information about the package #7

Closed
wants to merge 1 commit into from
Closed

Conversation

KirilNN
Copy link
Contributor

@KirilNN KirilNN commented Mar 25, 2016

@Underlog please take a look and let me know if any changes are needed.

Thanks

@petyosi
Copy link
Contributor

petyosi commented Mar 29, 2016

Shipping CSS files in a React component is not a standard approach. Most of the toolkits out there rely on inline styilng.

Given that, an example that shows the possible approaches will be necessary. We can host these in the examples directory.

@cosminnicula
Copy link

Inline styles are a delicate subject - you can see some details on this subject here mui/material-ui#1951

@petyosi
Copy link
Contributor

petyosi commented Mar 31, 2016

@cosminnicula Thanks for chimming in. We are hesitant to go into the inline styles direction. The Kendo UI react components are compatible with the existing Kendo UI themes, so we are using the same CSS classes.

@cosminnicula
Copy link

It might be a good idea though to have the CSS delivered as modular files (one file per component) and also to have support for namespacing (e.g. Sass variables in selectors through interpolation – .#{$css-prefix}).

@KirilNN
Copy link
Contributor Author

KirilNN commented May 12, 2016

@cosminnicula currently if you include more than one component styling in your project the CSS output might get duplicate values. We are currently working on a solution for this as well as better documentation about it.

@KirilNN KirilNN closed this May 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants