Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allows setting of pause dialog size in the conf.ini #515

Merged
merged 1 commit into from
Apr 25, 2017

Conversation

ppettit
Copy link
Collaborator

@ppettit ppettit commented Apr 24, 2017

our users had trouble with the tiny default pause button. they
often tried to click the disabled transport controls in the bottom
right to unpause and got confused when nothing happened.

to fix this we enlarged the pause button so that it is unmissable!

this adds that feature as a conf option:

[basic]
pausedialog_size = 70

the value is the percentage of the screen height you would like
the pause dialog to take up. 70 seems good for us.

this also scales the svg correctly to avoid a blurry icon.

our users had trouble with the tiny default pause button. they
often tried to click the disabled transport controls in the bottom
right to unpause and got confused when nothing happened.

to fix this we enlarged the pause button so that it is unmissable!

this adds that feature as a conf option:

```
[basic]
pausedialog_size = 70
```

the value is the percentage of the screen height you would like
the pause dialog to take up. 70 seems good for us.

this also scales the svg correctly to avoid a blurry icon.
@Alfro Alfro changed the base branch from 2.0.x to master April 25, 2017 12:07
@Alfro
Copy link
Contributor

Alfro commented Apr 25, 2017

Looks good!
I have moved this to master, as it changes the conf-dist.ini and adds a feature.

@Alfro Alfro merged commit c1b8137 into teltek:master Apr 25, 2017
@Alfro
Copy link
Contributor

Alfro commented Apr 25, 2017

Thanks!

@ppettit ppettit deleted the pausedialog_size branch May 2, 2017 16:27
@ppettit ppettit restored the pausedialog_size branch August 23, 2017 08:45
Alfro added a commit to teltek/Galicaster-doc that referenced this pull request Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants