improve plugin loading logging #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logs stack trace when something goes wrong inside the plugin (very useful when developing). also logs whether the plugin is internal or external when it loads, which helps understand which version of a plugin is loading (if you have installed plugin with pip as well as in the galicaster plugins directory for example).
|
actually, just thinking maybe the plugin loader should actually try loading external plugins first, so that internal ones can be overridden? happy to change that if it is a good idea. |
|
Seems okay. Thanks! |
|
I am not sure about overriding internal plugins with external ones though. What would the advantage be of overriding internal plugins vs directly modifying their code? |
|
thought maybe it would be easier to install an updated or modified version of a plugin that is part of galicaster. but actually i guess you could just make a copy and rename it if needed. was just a thought but i think you are right it is not necessary! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a small patch that changes no functionality, but i found it useful when writing plugins.
logs stack trace when something goes wrong inside the plugin
(very useful when developing). also logs whether the plugin is
internal or external when it loads, which helps understand which
version of a plugin is loading (if you have installed plugin with
pip as well as in the galicaster plugins directory for example).