Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial version of NDI sink #55

Merged
merged 4 commits into from
Mar 15, 2021
Merged

Add initial version of NDI sink #55

merged 4 commits into from
Mar 15, 2021

Conversation

sdroege
Copy link
Contributor

@sdroege sdroege commented Feb 25, 2021 •
edited
Loading 

The sink can accept audio or video directly, or if both should be
provided at once it is necesary to use the ndisinkcombiner before the
ndisink to merge both audio and video into the same stream.

Fixes https://github.com/teltek/gst-plugin-ndi/issues/10

This is on top of #54

@sdroege sdroege mentioned this pull request Feb 25, 2021
Closed
sdroege and others added 4 commits February 26, 2021 11:00
@sdroege
Add new timestamp mode based on the receive time and timecode
84e4fe7 
In addition to the old one based on the receive time and timestamp.

Also make that new mode the default as it will usually give more
accurate results because the timestamp is just the send time while the
timecode is usually set by the sender based on the media timestamps.
@sdroege
Add FFI bindings for NDIlib_send_instance_t and related functions
83962cb
@sdroege
Add safe bindings for the send API
e7b3b87 
Including creation of frames from GStreamer buffers.
@sdroege
Add initial version of NDI sink
2345c45 
The sink can accept audio or video directly, or if both should be
provided at once it is necesary to use the ndisinkcombiner before the
ndisink to merge both audio and video into the same stream.

Fixes teltek#10
@pnieto pnieto requested a review from samuvlad March 1, 2021 08:14
samuvlad
samuvlad approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@samuvlad samuvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job and thank you very much

@pnieto pnieto merged commit 50548c8 into teltek:master Mar 15, 2021
@sdroege sdroege deleted the sink branch March 15, 2021 12:08
@Riot-StefanSchindler
Copy link

hey - i am trying to use the ndisink with the decklink output -

would you be able to give an sample on who to use the ndisink for decklinkvideosrc and audiosrc ?
got video working with : - but moment i start to use the combiner with audio i am failing
gst-launch-1.0 decklinkvideosrc device-number=1 mode=1080p50 ! videoconvert ! 'video/x-raw, format=(string)YV12' ! ndisink

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuvlad samuvlad samuvlad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdroege @Riot-StefanSchindler @samuvlad @pnieto