Clean cloud folder in Makefile #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quinn-With-Two-Ns
approved these changes
Mar 22, 2024
|
hmm shouldn't we require approval to merge? |
|
I wonder if this was taken off recently due to the fact that most changes are merged automatically via GH workflow and that rule blocked it somehow. May want to start discussion internally on this. |
|
Closing as the approach of putting cloud protos with the rest of protos has been rejected at this time |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
In preparation for temporalio/api#378, the
cleantarget needs to work with a subdir likecloud, so since we have no non-generated code incloud, we just delete the entire directory onclean