Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TQ Stats docs #449

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Improve TQ Stats docs #449

merged 3 commits into from
Aug 27, 2024

Conversation

ShahabT
Copy link
Contributor

@ShahabT ShahabT commented Aug 26, 2024

What changed?

Why?

Breaking changes

Server PR

@ShahabT ShahabT requested review from a team as code owners August 26, 2024 18:22
// The difference between `tasks_add_rate` and `tasks_dispatch_rate` is a reliable metric for the rate at which
// backlog grows/shrinks. See `BacklogIncreaseRate`.
//
// Note: the actual tasks delivered to the workers may significantly higher than the numbers reported by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: workers may significantly be higher

Copy link
Member

@Shivs11 Shivs11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ShahabT ShahabT merged commit d761393 into master Aug 27, 2024
3 checks passed
@ShahabT ShahabT deleted the shahab/tqstats branch August 27, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants