Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new workflow id conflict policy page and updating subsequent pages #2727

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

jsundai
Copy link
Contributor

@jsundai jsundai commented Apr 2, 2024

Picked up work from #2698
This content is waiting on Temporal Server v1.24 release

Internal tracking: JIRA EDU-2155

temporalio/features#437

@jsundai jsundai requested a review from a team as a code owner April 2, 2024 21:43
@flossypurse
Copy link
Contributor

@stephanos We did some IA refactoring and decided to just pick up your content contribution from here: #2698

Can you review this PR at your convenience?

Copy link
Contributor

@stephanos stephanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@flossypurse flossypurse changed the title Adding new workflow id conflict policy page and updating subsequent pages Adding new workflow id conflict policy page and updating subsequent pages [Blocked on release] Apr 26, 2024
@flossypurse flossypurse changed the title Adding new workflow id conflict policy page and updating subsequent pages [Blocked on release] Adding new workflow id conflict policy page and updating subsequent pages Apr 26, 2024
@flossypurse flossypurse added the blocked-on-release These changes are waiting on a release from another component label Apr 26, 2024
@stephanos
Copy link
Contributor

stephanos commented Sep 5, 2024

@flossypurse this PR is now unblocked as we released the new Go version that includes this capability and the new API that makes use of it.

@stephanos
Copy link
Contributor

@jsundai this PR is now unblocked as we released the new Go version that includes this capability and the new API that makes use of it.

@stephanos stephanos removed the blocked-on-release These changes are waiting on a release from another component label Sep 9, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jsundai
❌ Cully Wakelin


Cully Wakelin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jsundai
Copy link
Contributor Author

jsundai commented Sep 12, 2024

Thanks, @stephanos 🙌

@jsundai jsundai merged commit 56d9b86 into main Sep 12, 2024
2 of 3 checks passed
@jsundai jsundai deleted the workflowidcftpolicy branch September 12, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants