Recover fallback on server configuration when resourceLabels are not specified #580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This PR recovers the possibility to define resource labels on server level (e.g.
server.podLabels
) rather than only within the scope of the server services (frontend, history, matching, worker).Why?
With the introduction of resourceLabels templatization (#539), the option to specify podLabels on server level has been discontinued. Presumably this was not done consciously.
In the old situation it worked as follows:
{{- with (default $.Values.server.podLabels $serviceValues.podLabels) }}
(source: https://github.com/temporalio/helm-charts/pull/539/files#diff-b8142966d328045abc62158c9a0c7b8492a97eb135757aea4a6941d4a80edb9e)
But in the new situation, in case the
component
equalsserver
only the resource labels (e.g.server.frontend.podLabels
) within the scope are used. If not specified, any values inserver.podLabels
are ignored.Checklist
helm install -f values.yaml --set server.frontend.podLabels.resourceLabel1="resourceTest1" debug . --dry-run --debug
resourceLabel1
to thetemporal-frontend
deployment.helm install -f values.yaml --set server.podLabels.serverLabel1="serverTest1" --set server.frontend.podLabels.resourceLabel1="resourceTest1" debug . --dry-run --debug
resourceLabel1
to thetemporal-frontend
deployment.helm install -f values.yaml --set server.podLabels.serverLabel1="serverTest1" debug . --dry-run --debug
serverLabel1
to thetemporal-frontend
deployment (and other server services).serverLabel1
is added to all server services.No.