Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: interceptors plugins support #322

Merged
merged 5 commits into from
Feb 6, 2023

Conversation

cv65kr
Copy link
Contributor

@cv65kr cv65kr commented Feb 4, 2023

Reason for This PR

roadrunner-server/roadrunner#1313

Description of Changes

Possibility to use custom interceptors for Temporal.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian rustatian self-requested a review February 4, 2023 00:26
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Feb 4, 2023
@rustatian rustatian changed the title feat: Custom interceptors for Temporal feature: interceptors plugins support Feb 4, 2023
plugin.go Outdated Show resolved Hide resolved
plugin.go Outdated Show resolved Hide resolved
common/interfaces.go Outdated Show resolved Hide resolved
@rustatian
Copy link
Collaborator

Hey @cv65kr 👋🏻

It would be nice to have tests for the new temporal interceptors. You may write a dummy plugin-interceptor as I wrote in many places in the rr-e2e-test (e.g: link) and do some processing in it and then check the output.

@cv65kr
Copy link
Contributor Author

cv65kr commented Feb 4, 2023

@rustatian code improvements are done. Will write some test soon.

@codecov-commenter
Copy link

Codecov Report

Merging #322 (7d6f210) into master (75b8acb) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##           master    #322      +/-   ##
=========================================
- Coverage    3.71%   3.68%   -0.03%     
=========================================
  Files          19      19              
  Lines        1644    1657      +13     
=========================================
  Hits           61      61              
- Misses       1581    1594      +13     
  Partials        2       2              
Impacted Files Coverage Δ
aggregatedpool/workers.go 0.00% <0.00%> (ø)
plugin.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rustatian rustatian self-requested a review February 6, 2023 12:32
Copy link
Collaborator

@rustatian rustatian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rustatian rustatian merged commit f737aff into temporalio:master Feb 6, 2023
@rustatian
Copy link
Collaborator

Thanks @cv65kr 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants